Skip to content

Suggestion to remove "Start discussion and close merge request" button

Description

With the new resolvable discussion feature in 9.1 (#24378 (closed)), I've noticed a button that I don't understand the use case for:

Screen_Shot_2017-04-24_at_9.32.55_AM

The description of "Start Discussion" says:

Screen_Shot_2017-04-24_at_9.34.30_AM

I don't understand the use case under which I would start a discussion that needs resolution and at the same time close the merge request. That said, in the review workflows I'm used to, I don't think "Comment & close merge request" would be a common option either, so maybe I'm missing "Close issue" use cases, such as an escalated form of "blocking".

I do think that the "Start discussion & reopen merge request" button is sensible.

Proposal

Don't provide the "Start discussion & close merge request" option by disabling the outline-button when "Start discussion" is selected.

Edited by Taurie Davis