Skip to content

Tech debt: Jasmine unit tests change global window.location object and don't change it back

In several tests we modify the window.location object by using pushState but we never "reset" the state which causes other tests that need to check window.location to fail.

From Slack, @lbennett suggested:

We could have some utility method with is redirect or whatever, and in there we're just calling through and setting the right location stuff that we want to do our redirects Then in our tests we just need to spy on a utility function instead of restricting a global objects actions

cc @jschatz1 @lbennett