Broken spec on master: spec/services/projects/update_service_spec.rb
36fce925 introduced a change which introduces an order dependency, breaking specs on master:
itlab-mbp:gitlab lupine$ bundle exec rspec spec/models/namespace_spec.rb:139 spec/services/projects/update_service_spec.rb:67
Run options: include {:locations=>{"./spec/models/namespace_spec.rb"=>[139], "./spec/services/projects/update_service_spec.rb"=>[67]}}
fatal: destination path '/Users/lupine/dev/gitlab.com/gitlab-org/gdk-ee/gitlab/tmp/tests/gitlab-test_bare' already exists and is not an empty directory.
1) Projects::UpdateService visibility_level updates forks visibility level when parent set to more restrictive
Failure/Error: FileUtils.cp_r("#{base_repo_path}/.", target_repo_path)
RuntimeError:
unknown file type: /Users/lupine/dev/gitlab.com/gitlab-org/gdk-ee/gitlab/tmp/tests/gitlab-test-fork_bare/.
# ./spec/support/test_env.rb:165:in `copy_forked_repo_with_submodules'
# ./spec/factories/projects.rb:204:in `block (3 levels) in <top (required)>'
# /Users/lupine/.gem/ruby/2.3.1/gems/factory_girl-4.7.0/lib/factory_girl/callback.rb:13:in `instance_exec'
# /Users/lupine/.gem/ruby/2.3.1/gems/factory_girl-4.7.0/lib/factory_girl/callback.rb:13:in `run'
# /Users/lupine/.gem/ruby/2.3.1/gems/factory_girl-4.7.0/lib/factory_girl/callbacks_observer.rb:11:in `block in update'
# /Users/lupine/.gem/ruby/2.3.1/gems/factory_girl-4.7.0/lib/factory_girl/callbacks_observer.rb:10:in `each'
# /Users/lupine/.gem/ruby/2.3.1/gems/factory_girl-4.7.0/lib/factory_girl/callbacks_observer.rb:10:in `update'
# /Users/lupine/.gem/ruby/2.3.1/gems/factory_girl-4.7.0/lib/factory_girl/evaluation.rb:20:in `notify'
# /Users/lupine/.gem/ruby/2.3.1/gems/factory_girl-4.7.0/lib/factory_girl/strategy/create.rb:13:in `block in result'
# /Users/lupine/.gem/ruby/2.3.1/gems/factory_girl-4.7.0/lib/factory_girl/strategy/create.rb:9:in `tap'
# /Users/lupine/.gem/ruby/2.3.1/gems/factory_girl-4.7.0/lib/factory_girl/strategy/create.rb:9:in `result'
# /Users/lupine/.gem/ruby/2.3.1/gems/factory_girl-4.7.0/lib/factory_girl/factory.rb:42:in `run'
# /Users/lupine/.gem/ruby/2.3.1/gems/factory_girl-4.7.0/lib/factory_girl/factory_runner.rb:29:in `block in run'
# /Users/lupine/.gem/ruby/2.3.1/gems/activesupport-4.2.8/lib/active_support/notifications.rb:166:in `instrument'
# /Users/lupine/.gem/ruby/2.3.1/gems/factory_girl-4.7.0/lib/factory_girl/factory_runner.rb:28:in `run'
# /Users/lupine/.gem/ruby/2.3.1/gems/factory_girl-4.7.0/lib/factory_girl/strategy_syntax_method_registrar.rb:20:in `block in define_singular_strategy_method'
# ./spec/services/projects/update_service_spec.rb:60:in `block (3 levels) in <top (required)>'
# ./spec/services/projects/update_service_spec.rb:63:in `block (3 levels) in <top (required)>'
# /Users/lupine/.gem/ruby/2.3.1/gems/rspec-retry-0.4.5/lib/rspec/retry.rb:98:in `block in run'
# /Users/lupine/.gem/ruby/2.3.1/gems/rspec-retry-0.4.5/lib/rspec/retry.rb:88:in `loop'
# /Users/lupine/.gem/ruby/2.3.1/gems/rspec-retry-0.4.5/lib/rspec/retry.rb:88:in `run'
# /Users/lupine/.gem/ruby/2.3.1/gems/rspec-retry-0.4.5/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
# /Users/lupine/.gem/ruby/2.3.1/gems/rspec-retry-0.4.5/lib/rspec/retry.rb:22:in `block (2 levels) in setup'
2/2 |================================================== 100 ===================================================>| Time: 00:00:09
Finished in 10.15 seconds (files took 21.17 seconds to load)
2 examples, 1 failure
Failed examples:
rspec ./spec/services/projects/update_service_spec.rb:67 # Projects::UpdateService visibility_level updates forks visibility level when parent set to more restrictive