Large Diff Hide Whitespace & Comment Bug
Summary
Hiding whitespace changes on a HUGE diff, gives the option to make a comment, but it does not get properly saved
Steps to reproduce
Here are two example files that hits the spot.
- Commit the
orig
file on the master branch. - Commit the
new
file on a different branch and create a MR - View the changes, see nothing, too many changes
- Click the Hide Whitespace Changes and see the two lines changed
- Make a comment on one of those two lines
- Pressing save does nothing on 9.0 (or on GitLab.com). 8.17.x it saved in the front-end like shown in the video, but was gone once the page refreshed.
What is the current bug behavior?
The user thinks they can make a commend, and type it into the comment box, on 8.17.x the saves it in the front-end but when the page refreshes it is gone, in 9.0.0 the save button does not work.
What is the expected correct behavior?
The comment should be saved, or if there is a performance reason comments can't be made on such large diffs, the user should not be given the option.
Relevant logs and/or screenshots
Video from the customer https://drive.google.com/file/d/0By3-UhPj1nVmamFUMGlHVXhjTUk/view
Here is an example project open where you can try it. https://gitlab.com/dewetblomerus/whitespace-bug/merge_requests/1/diffs?w=1