Unnecessary "include WaitForAjax"
Problem
We have quite a lot of
include WaitForAjax
lines in our test suite. It seems to be unnecessary because in spec_helper.rb
we do:
config.include WaitForAjax, type: :feature
To make things even funnier (worse) in spec/features/projects/features_visibility_spec.rb
and spec/features/projects/commit/cherry_pick_spec.rb
we include this module at the file level which means global namespace (?).
What to do it
- Remove cases when it's included at the file level
- Remove all other cases when it's manually included
- Include it automatically for all
:js
specs (instead of:feature
)