Activity stream unable to display comments with emoji

Where

Undefined method block? for nil:NilClass in app/helpers/gitlab_markdown_helper.rb

  def truncate_if_block(node, truncated)
    if node.element? && node.description.block? && !truncated
      node.inner_html = "#{node.inner_html}..." if node.next_sibling
      true
    else
      truncated
    end
  end

References

https://sentry.gitlap.com/gitlab/staginggitlabcom/issues/23013/
https://sentry.gitlap.com/gitlab/staginggitlabcom/issues/23017/

added ~12980 ~1276481 labels

Managed to reproduce! Create a comment including an emoji

changed title from {-Undefined method block? for nil:NilClass when viewing comment activity stream-} to Activity stream unable to display comments with emoji

@MadLittleMods Could this be related to https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9570?

added ~17876 label

changed milestone to %9.0

@jamedjo Maybe? Still trying to reproduce. I am not able to reproduce by posting a emoji comment on an issue. Update: Ahh, post an emoji comment and visit the user profile (per the label).

I can reproduce when adding a test in gitlab_markdown_helper_spec.rb -> #first_line_in_markdown, text = "foo :wink:\n"

---

Should we have a null check on node.description in any case though?

I am not sure what is adding node.description or why it is a guranteed/expected. I don't see it in the Banzai codebase See Nokogiri parsing in truncate_visible and those gets passed into truncate_if_block

#description ⇒ Object

Fetch the Nokogiri::HTML::ElementDescription for this node. Returns nil on XML documents and on unknown tags.

http://www.rubydoc.info/github/sparklemotion/nokogiri/Nokogiri/XML/Node#description-instance_method

Not sure why <gl-emoji> would be different from a <img> tag Per the error, node.element? is true for <gl-emoji> and node.description is nil. So either <img> gave node.element? false or was true and had a node.description.

• <gl-emoji> has a nil description because it is a unknown tag
• <img> gives a description with .block? being false

assigned to @MadLittleMods

mentioned in commit 53aff128

mentioned in merge request !9920 (merged)

Fix is here, https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9920

changed milestone to %8.17

added ~80193 label

@collen I don't think this relates to ~2fa, and is probably 9.0 milestone as 'Native Unicode Emojis' was only merged last week. Wrong issue?

removed ~80193 label

removed milestone

mentioned in issue #29453 (closed)

mentioned in commit 3e29936a

closed via merge request !9920 (merged)

mentioned in commit 068fe615

mentioned in commit 2e051060