Incorrect status shown on project page when pipeline re-launched for master

Summary

The pipeline status may be shown incorrectly in the project page. In my case the windows build on the master branch failed for the first time, but the problem was not in the source code but on one of the runners. After I fixed the problem on the runner and re-launched the pipeline for the master again (same commit), it succeeded.

However, the project page still showed "failed" for that commit.

See screenshots below.

Steps to reproduce

Make a pipeline fail on master by making some problem on a runner. Correct the problem on the runner. Launch the pipeline for the master again while the head of the master is at the same commit.

Expected behavior

The status of the master branch should be "passed".

Actual behavior

The status of the master branch is "failed".

Relevant logs and/or screenshots

Screen_Shot_2016-12-11_at_17.36.10Screen_Shot_2016-12-11_at_17.39.09

Results of GitLab application Check

$ sudo gitlab-rake gitlab:check SANITIZE=true
Checking GitLab Shell ...

GitLab Shell version >= 4.0.0 ? ... OK (4.0.0)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by git:git?
default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ... 
4/1 ... ok
4/3 ... ok
2/4 ... ok
2/6 ... ok
4/8 ... repository is empty
4/9 ... ok
4/10 ... ok
4/11 ... ok
4/12 ... ok
4/14 ... ok
4/15 ... ok
4/16 ... repository is empty
4/17 ... ok
4/18 ... ok
12/25 ... ok
4/27 ... ok
4/28 ... ok
4/30 ... ok
40/33 ... ok
40/34 ... ok
4/35 ... ok
32/36 ... ok
32/37 ... ok
42/38 ... ok
7/39 ... ok
45/41 ... ok
12/42 ... ok
2/43 ... ok
2/44 ... ok
2/45 ... ok
2/46 ... repository is empty
2/47 ... ok
4/48 ... ok
2/49 ... ok
2/50 ... repository is empty
2/51 ... repository is empty
2/52 ... repository is empty
4/53 ... ok
4/55 ... ok
3/56 ... ok
4/57 ... ok
26/58 ... ok
13/59 ... ok
12/60 ... ok
4/64 ... ok
40/65 ... ok
57/66 ... ok
51/68 ... ok
48/73 ... ok
57/74 ... ok
57/75 ... ok
28/76 ... ok
57/77 ... ok
2/78 ... ok
2/79 ... ok
4/80 ... ok
2/83 ... ok
12/88 ... ok
2/92 ... ok
42/93 ... ok
57/94 ... ok
8/96 ... ok
31/97 ... ok
42/98 ... repository is empty
54/99 ... ok
66/100 ... ok
4/101 ... ok
40/102 ... ok
32/103 ... ok
54/104 ... ok
4/107 ... ok
16/108 ... ok
12/109 ... ok
45/110 ... ok
54/111 ... ok
54/112 ... ok
32/114 ... ok
60/115 ... ok
59/116 ... ok
14/117 ... ok
4/120 ... ok
4/121 ... ok
57/123 ... ok
57/124 ... ok
42/125 ... ok
69/128 ... ok
4/130 ... ok
4/131 ... ok
60/132 ... ok
57/133 ... ok
73/134 ... ok
4/136 ... ok
4/137 ... ok
5/140 ... ok
69/141 ... ok
4/142 ... ok
8/143 ... ok
54/144 ... ok
50/145 ... ok
26/146 ... ok
5/147 ... ok
4/148 ... ok
4/149 ... ok
57/150 ... ok
50/151 ... ok
42/152 ... repository is empty
5/153 ... ok
54/154 ... ok
79/156 ... ok
57/157 ... ok
57/158 ... ok
57/159 ... ok
54/162 ... ok
82/163 ... ok
57/165 ... ok
57/166 ... ok
79/167 ... ok
12/168 ... ok
57/169 ... ok
83/170 ... ok
39/171 ... ok
54/172 ... ok
69/173 ... ok
39/174 ... ok
84/175 ... ok
62/179 ... repository is empty
69/180 ... ok
4/182 ... ok
86/183 ... ok
69/184 ... ok
69/185 ... ok
6/186 ... ok
5/188 ... ok
69/189 ... ok
6/190 ... ok
4/191 ... ok
69/192 ... ok
4/193 ... ok
54/194 ... ok
99/196 ... repository is empty
37/197 ... ok
32/198 ... ok
5/199 ... ok
42/200 ... ok
42/201 ... ok
54/204 ... ok
8/205 ... ok
78/207 ... ok
5/211 ... ok
50/213 ... ok
107/214 ... ok
57/216 ... ok
116/217 ... ok
4/218 ... ok
57/219 ... ok
62/221 ... ok
84/222 ... ok
62/223 ... ok
32/224 ... ok
32/225 ... ok
98/229 ... ok
62/230 ... ok
32/231 ... ok
4/233 ... ok
4/234 ... ok
19/235 ... ok
19/236 ... ok
127/238 ... ok
50/239 ... ok
19/240 ... ok
19/241 ... ok
62/243 ... ok
5/244 ... ok
24/245 ... ok
4/246 ... ok
5/247 ... ok
57/248 ... ok
57/249 ... ok
6/252 ... ok
119/253 ... ok
5/256 ... ok
98/257 ... ok
99/258 ... ok
99/259 ... ok
32/260 ... ok
4/261 ... ok
57/262 ... ok
60/264 ... ok
57/265 ... ok
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK
Send ping to redis server: OK
gitlab-shell self-check successful

Checking GitLab Shell ... Finished

Checking Sidekiq ...

Running? ... yes
Number of Sidekiq processes ... 1

Checking Sidekiq ... Finished

Checking Reply by email ...

Reply by email is disabled in config/gitlab.yml

Checking Reply by email ... Finished

Checking LDAP ...

LDAP is disabled in config/gitlab.yml

Checking LDAP ... Finished

Checking GitLab ...

Git configured with autocrlf=input? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config outdated? ... no
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory setup correctly? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
projects have namespace: ... 
4/1 ... yes
4/3 ... yes
2/4 ... yes
2/6 ... yes
4/8 ... yes
4/9 ... yes
4/10 ... yes
4/11 ... yes
4/12 ... yes
4/14 ... yes
4/15 ... yes
4/16 ... yes
4/17 ... yes
4/18 ... yes
12/25 ... yes
4/27 ... yes
4/28 ... yes
4/30 ... yes
40/33 ... yes
40/34 ... yes
4/35 ... yes
32/36 ... yes
32/37 ... yes
42/38 ... yes
7/39 ... yes
45/41 ... yes
12/42 ... yes
2/43 ... yes
2/44 ... yes
2/45 ... yes
2/46 ... yes
2/47 ... yes
4/48 ... yes
2/49 ... yes
2/50 ... yes
2/51 ... yes
2/52 ... yes
4/53 ... yes
4/55 ... yes
3/56 ... yes
4/57 ... yes
26/58 ... yes
13/59 ... yes
12/60 ... yes
4/64 ... yes
40/65 ... yes
57/66 ... yes
51/68 ... yes
48/73 ... yes
57/74 ... yes
57/75 ... yes
28/76 ... yes
57/77 ... yes
2/78 ... yes
2/79 ... yes
4/80 ... yes
2/83 ... yes
12/88 ... yes
2/92 ... yes
42/93 ... yes
57/94 ... yes
8/96 ... yes
31/97 ... yes
42/98 ... yes
54/99 ... yes
66/100 ... yes
4/101 ... yes
40/102 ... yes
32/103 ... yes
54/104 ... yes
4/107 ... yes
16/108 ... yes
12/109 ... yes
45/110 ... yes
54/111 ... yes
54/112 ... yes
32/114 ... yes
60/115 ... yes
59/116 ... yes
14/117 ... yes
4/120 ... yes
4/121 ... yes
57/123 ... yes
57/124 ... yes
42/125 ... yes
69/128 ... yes
4/130 ... yes
4/131 ... yes
60/132 ... yes
57/133 ... yes
73/134 ... yes
4/136 ... yes
4/137 ... yes
5/140 ... yes
69/141 ... yes
4/142 ... yes
8/143 ... yes
54/144 ... yes
50/145 ... yes
26/146 ... yes
5/147 ... yes
4/148 ... yes
4/149 ... yes
57/150 ... yes
50/151 ... yes
42/152 ... yes
5/153 ... yes
54/154 ... yes
79/156 ... yes
57/157 ... yes
57/158 ... yes
57/159 ... yes
54/162 ... yes
82/163 ... yes
57/165 ... yes
57/166 ... yes
79/167 ... yes
12/168 ... yes
57/169 ... yes
83/170 ... yes
39/171 ... yes
54/172 ... yes
69/173 ... yes
39/174 ... yes
84/175 ... yes
62/179 ... yes
69/180 ... yes
4/182 ... yes
86/183 ... yes
69/184 ... yes
69/185 ... yes
6/186 ... yes
5/188 ... yes
69/189 ... yes
6/190 ... yes
4/191 ... yes
69/192 ... yes
4/193 ... yes
54/194 ... yes
99/196 ... yes
37/197 ... yes
32/198 ... yes
5/199 ... yes
42/200 ... yes
42/201 ... yes
54/204 ... yes
8/205 ... yes
78/207 ... yes
5/211 ... yes
50/213 ... yes
107/214 ... yes
57/216 ... yes
116/217 ... yes
4/218 ... yes
57/219 ... yes
62/221 ... yes
84/222 ... yes
62/223 ... yes
32/224 ... yes
32/225 ... yes
98/229 ... yes
62/230 ... yes
32/231 ... yes
4/233 ... yes
4/234 ... yes
19/235 ... yes
19/236 ... yes
127/238 ... yes
50/239 ... yes
19/240 ... yes
19/241 ... yes
62/243 ... yes
5/244 ... yes
24/245 ... yes
4/246 ... yes
5/247 ... yes
57/248 ... yes
57/249 ... yes
6/252 ... yes
119/253 ... yes
5/256 ... yes
98/257 ... yes
99/258 ... yes
99/259 ... yes
32/260 ... yes
4/261 ... yes
57/262 ... yes
60/264 ... yes
57/265 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.1.0 ? ... yes (2.3.1)
Your git bin path is "/opt/gitlab/embedded/bin/git"
Git version >= 2.7.3 ? ... yes (2.7.4)
Active users: 131

Checking GitLab ... Finished

Results of GitLab environment info

$ sudo gitlab-rake gitlab:env:info

System information
System:		
Current User:	git
Using RVM:	no
Ruby Version:	2.3.1p112
Gem Version:	2.6.6
Bundler Version:1.13.6
Rake Version:	10.5.0
Sidekiq Version:4.2.1

GitLab information
Version:	8.14.1
Revision:	e45bf3d
Directory:	/opt/gitlab/embedded/service/gitlab-rails
DB Adapter:	postgresql
URL:		https://cmiclab.cs.ucl.ac.uk
HTTP Clone URL:	https://cmiclab.cs.ucl.ac.uk/some-group/some-project.git
SSH Clone URL:	git@cmiclab.cs.ucl.ac.uk:some-group/some-project.git
Using LDAP:	no
Using Omniauth:	no

GitLab Shell
Version:	4.0.0
Repository storage paths:
- default: 	/cs/research/medic/cmiclab/git-data/repositories
Hooks:		/opt/gitlab/embedded/service/gitlab-shell/hooks/
Git:		/opt/gitlab/embedded/bin/git

Possible fixes

Not aware of.