"Prevent merge until Review is done" feature should be available without builds enabled on project
Summary
"Prevent merge until Review is done" feature should be available without builds enabled on project.
Steps to reproduce
- Open project settings
- Set builds disabled
"Merge requests" block will be hidden.
Expected behavior
When builds disabled unly "Only allow merge requests to be merged if the build succeeds " should be hidden.
"Only allow merge requests to be merged if all discussions are resolved" flag must be visible until "merge requests" feature enabled.
Actual behavior
When disabling builds all "Merge requests" block will be hidden.
Relevant logs and/or screenshots
Output of checks
Results of GitLab application Check
Checking GitLab Shell ...
GitLab Shell version >= 4.0.0 ? ... OK (4.0.0)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by git:git?
default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ...
3/3 ... ok
3/4 ... ok
8/5 ... ok
8/6 ... ok
8/7 ... ok
8/8 ... ok
14/14 ... ok
14/15 ... ok
18/21 ... ok
18/23 ... ok
12/25 ... ok
12/26 ... ok
9/27 ... ok
12/28 ... ok
14/31 ... ok
14/34 ... ok
14/36 ... ok
15/37 ... ok
15/38 ... ok
16/41 ... ok
2/42 ... ok
10/45 ... ok
10/53 ... ok
18/55 ... ok
18/56 ... ok
10/58 ... ok
10/59 ... ok
10/60 ... ok
10/61 ... ok
10/62 ... ok
2/64 ... ok
8/68 ... ok
14/69 ... ok
14/72 ... ok
14/73 ... ok
2/74 ... ok
8/78 ... ok
18/79 ... ok
18/80 ... ok
10/81 ... ok
8/89 ... ok
14/90 ... ok
2/92 ... ok
18/94 ... ok
8/95 ... ok
8/97 ... ok
14/100 ... ok
28/112 ... ok
28/115 ... ok
8/116 ... ok
8/117 ... ok
8/118 ... ok
14/126 ... ok
29/127 ... ok
14/128 ... ok
31/129 ... ok
31/130 ... ok
14/131 ... ok
18/132 ... ok
18/133 ... ok
3/139 ... ok
18/141 ... ok
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK
Send ping to redis server: OK
gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes
Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Reply by email ...
IMAP server credentials are correct? ... yes
Init.d configured correctly? ... skipped (omnibus-gitlab has no init script)
MailRoom running? ... can't check because of previous errors
Checking Reply by email ... Finished
Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured with autocrlf=input? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config outdated? ... no
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory setup correctly? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
projects have namespace: ...
3/3 ... yes
3/4 ... yes
8/5 ... yes
8/6 ... yes
8/7 ... yes
8/8 ... yes
14/14 ... yes
14/15 ... yes
18/21 ... yes
18/23 ... yes
12/25 ... yes
12/26 ... yes
9/27 ... yes
12/28 ... yes
14/31 ... yes
14/34 ... yes
14/36 ... yes
15/37 ... yes
15/38 ... yes
16/41 ... yes
2/42 ... yes
10/45 ... yes
10/53 ... yes
18/55 ... yes
18/56 ... yes
10/58 ... yes
10/59 ... yes
10/60 ... yes
10/61 ... yes
10/62 ... yes
2/64 ... yes
8/68 ... yes
14/69 ... yes
14/72 ... yes
14/73 ... yes
2/74 ... yes
8/78 ... yes
18/79 ... yes
18/80 ... yes
10/81 ... yes
8/89 ... yes
14/90 ... yes
2/92 ... yes
18/94 ... yes
8/95 ... yes
8/97 ... yes
14/100 ... yes
28/112 ... yes
28/115 ... yes
8/116 ... yes
8/117 ... yes
8/118 ... yes
14/126 ... yes
29/127 ... yes
14/128 ... yes
31/129 ... yes
31/130 ... yes
14/131 ... yes
18/132 ... yes
18/133 ... yes
3/139 ... yes
18/141 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.1.0 ? ... yes (2.3.1)
Your git bin path is "/opt/gitlab/embedded/bin/git"
Git version >= 2.7.3 ? ... yes (2.7.4)
Active users: 3
Checking GitLab ... Finished
Results of GitLab environment info
System information
System: Ubuntu 14.04
Current User: git
Using RVM: no
Ruby Version: 2.3.1p112
Gem Version: 2.6.6
Bundler Version:1.13.6
Rake Version: 10.5.0
Sidekiq Version:4.2.1
GitLab information
Version: 8.14.1
Revision: e45bf3d
Directory: /opt/gitlab/embedded/service/gitlab-rails
DB Adapter: postgresql
URL: https://lab.raxei.net
HTTP Clone URL: https://lab.raxei.net/some-group/some-project.git
SSH Clone URL: git@lab.raxei.net:some-group/some-project.git
Using LDAP: no
Using Omniauth: no
GitLab Shell
Version: 4.0.0
Repository storage paths:
- default: /mnt/data/git-repos/repositories
Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks/
Git: /opt/gitlab/embedded/bin/git