Skip to content
GitLab
Next
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 22
    • Issues 22
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLab FOSSGitLab FOSS
  • Issues
  • #25140
Closed
Open
Issue created Nov 29, 2016 by Mark Pundsack@markpundsackContributor

Show enhanced information on running deploys in MR Widget

Problem to Solve

Currently, environment information gets hidden when a newer pipeline is running. Also, as post merge pipelines currently replaces the feature branch pipeline, that information becomes hidden in a confusing way.

Further details`

Use case

When a deploy has happened which put the code in an MR into an environment, we show a message in the system information box saying so. As a developer working on that MR, I'd like to see when a deploy is actively happening that will deploy the MR to an environment. Usually, while the MR is open, this is covered by the running pipeline message, where I can click through and see that a deploy is going to happen, etc. But once the MR is merged, that pipeline notice goes away. But a deploy of that MRs code may still be ongoing. e.g. when a MR merges into master and triggers a deploy to staging. When the deploy is finished, a new message will appear, but again, nothing before the deploy is finished.

We now have a similar message on build detail pages that the build will deploy, and we can do that on MR pages too.

image

Considerations

This is how the review app link appears today when your pipeline has completed and the review app is available:

image

One additional issue is that if someone starts a new deployment the link to the latest review app disappears. The old one is still there and running (at least in normal cases) and there's still value to seeing the last version, with the affirmative understanding that it's actively being updated.

image

In busy merge requests, you may vary rarely or even never see the review app link unless this is changed. Instead of making the review app link disappear, it should still display a link to the currently running older review app along with a warning that a new deployment is already underway.

Solution

  • Have either deploying/deployed states for environments information
  • If it's the first time we're deploying, the link will be a 404
  • During deployment the stop button will be disabled + tooltip explaining why
  • If a pipeline fails to deploy, deployment info will be hidden
  • Post merge deploys target branch pipeline is shown under merge section in merge request widget, including env information
  • Stop env button is hidden for post merge environments moved to gitlab-ee#8148
Before After
Pre-merge deployment is deploying Does not exist yet Artboard_2
Pre-merge deployment finished Artboard Nothing changes
Post-merge deployment is deploying after merge Does not exist yet aa
Post-merge deployment finished Is not shown atm (got removed?) aa

BE patch additional edits

Changes will be done for 11.5 for BE only

  • merge request deployment “created” status will display the same as “running” status => pipeline is deploying to env

  • merge request deployment “cancelled” status will display the same as “failed” status => pipeline has failed deploying to env

It will reuse the existing FE for the “running” and “failed” status for the “created” and “cancelled” status.

What does success look like, and how can we measure that?

A person is able to:

  • See both pre and post-merge pipeline + env information
  • See the which deploys are in progress

Links / references

Edited Nov 14, 2018 by Achilleas Pipinellis
Assignee
Assign to
Time tracking