Switching project from private to public, still requires authentication

Summary

When creating a project initially as private (requiring auth) then moving it to public (via Edit Project), the expectation is no auth would be required. This doesn't seem to be the case.

Steps to reproduce

1 - Create a private project (did it via the gui). 2 - Add something to Readme save 3 - clone project locally (username/pwd prompt) 4 - change via Edit Project (public), and save 5 - clone project again locally

Expected behavior

Switching project to public, should no longer prompt for for username/password

Actual behavior

Prompts for auth.

Relevant logs and/or screenshots

Output of checks

Results of GitLab application Check

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:check SANITIZE=true)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)

(we will only investigate if the tests are passing)

Results of GitLab environment info

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:env:info)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production)

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)