Merge requests with no discussions cannot be merged when "Only allow merge requests to be merged if all discussions are resolved" is enabled.

Summary

When Only allow merge requests to be merged if all discussions are resolved is enabled at the project level, an approver can approve the merge and create no discussion topics, yet the merge request reports that This merge request has unresolved discussions. Please resolve these discussions to allow this merge request to be merged.

Steps to reproduce

  1. On a project, enable Only allow merge requests to be merged if all discussions are resolved
  2. Create a new branch with a change, commit, and initiate a merge request
  3. Ensure that the merge request requires an approver before allowing the merge request to be completed
  4. Have an approver approve the merge request with no discussions topics
  5. Notice the merge request does now allow the merge to go through, stating there are unresolved discussion topics

Expected behavior

If there are no discussion topics created from the code review/approval process, then the merge request should be allowed to be completed.

Actual behavior

The merge request is blocked, stating This merge request has unresolved discussions. Please resolve these discussions to allow this merge request to be merged.

Relevant logs and/or screenshots

See current merge request here: https://gitlab.com/GitLabRGI/swagd-geopackage-verifier/merge_requests/2

Output of checks

Results of GitLab application Check

This is happening on GitLab.com

Results of GitLab environment info

This is happening on GitLab.com

Possible fixes

Turn off Only allow merge requests to be merged if all discussions are resolved