"All" tab in activity feed doesn't show all events
When starting a new Gitlab session and navigating to the activity feed, no event filter is selected and all events are shown in the feed; including events about (re-)opened and closed issues. Now, when I click on the "All" filter, those disappear from the feed, which doesn't feel right, as when I click "All" I expect to see all events. Furthermore, once selected, you can't untoggle the filters, which makes it impossible to get back the complete feed.
Having the complete feed including opened and closed issues is quite important to me, as I'm working in a small organization where we use Gitlab issues to get user feedback. The activity feed is a great way to keep updated with the changes other developers are making as well as the needs of our users, and I'd like not to disappoint our users because we didn't see their issue :) In total we get only a couple of issues each day across 20 or so projects, so manually checking each project for new issues isn't really worth the time.
This behaviour is caused by the implementation of the EventFilter
class which whitelists the event types that are shown when the All-tab is selected, instead of just showing everything. I suppose updating this list has been forgotten when some new event types were added, but I'm not completely sure of that. My proposed solution is to just remove the whitelist and always show all events (see !7673 (merged)).
Proposed UX
- Make sure
All
actually includes all activity - Add
Issue events
tab to include the specific events around opening and closing issues, etc. - Make the
All
tab selected by default.