An error occurred while fetching the assigned iteration of the selected issue.
":" handling in notes / French typography
Summary
In French typography, a colon (":") is prefixed by a space.
i.e:
Choses à faire :
- Aller chercher du lait
- Revenir
In a note, when the ":" character is entered after a space, the "atWho" autocomplete pops up.
It was already a little annoying for French users but has gotten worse since the "Esc" key has been bound to note deletion (it used to close the autocomplete).
A very realistic scenario follows:
- The user types a space and a ":"
- The popup menu... pops up
- The user wants to dismiss it and, following his/her initial intent, wants to insert a carriage return: hits "Esc" and "Enter"
- The note is deleted!
Steps to reproduce
Type in a note:
Bonjour :<esc><enter>
Expected behavior
Maybe make the default choice be "Cancel"?
Or don't fire this dialog if the "atWho" autocomplete is currently shown?
Actual behavior
The note disappears
Possible fixes
See Expected Behavior.
File locations:
- ":" handler is setup in gfm_auto_complete.js.es6 line 78
- confirmation is setup in notes.js lines 137 and 149