Suggestion: Open / closed not as a tab but as a dropdown
Activity
Also mentioned at https://gitlab.com/gitlab-org/gitlab-ce/issues/20154.
-
I like it as tabs as it gives a fast way to look at closed issues assigned to me at Dashboard / Issues. Also I believe for small projects open/closed filtering is primary one to use.
Anyway I believe this issue should be considered only after we implement smart filtering - https://gitlab.com/gitlab-org/gitlab-ce/issues/21747. Right now its too much dropdown filters on issues page
I am strongly against it. And I agree with @dzaporozhets's arguments. Another major reason: Now that #15356 (closed) got fixed (coming in %8.13), the number badges in the tabs will actually show the number of open/closed issues/MRs after filtering. That is a big deal as it gives you immediate (and extremely valuable) feedback to your filters/search.
- It helps finding issues quickly (example: i have a pretty good idea what I'm looking for but the issue got closed a few minutes ago. Applying filters show 0 open issues but >0 closed ones.)
- It helps getting an idea how many issues concerning one topic/component exist in total (currently impossible, as the counters don't change)
- It helps avoiding the creation of duplicate issues (example: searching for a specific error message gives 0 open issues but 1 closed one)
In other words: Seeing the count for both open and closed issues/MRs at a glance is helpful. A dropdown doesn't allow this.
Yes, I agree with both @dzaporozhets and @pbr. I think the state of the issue makes sense as tabs, not a dropdown. Especially because of the point about viewing the number of open/closed issues/MRs after filtering.
Edited by Taurie Davis-
Right now replacing tabs with dropdowns wont bring us any benefits:
- we still have 2 rows (1st with search + new issue button and 2nd with dropdowns)
- we dont have enough space on second row with filter dropdowns
I propose we actually finish https://gitlab.com/gitlab-org/gitlab-ce/issues/21747 first and then consider doing something with Open/Closed tabs so we have all filtering in one row.
Let's do smart filtering first https://gitlab.com/gitlab-org/gitlab-ce/issues/21747
Not sure if it is worth losing the counters.
Mentioned in issue #23540 (moved)
