This is somehow a follow up from #3976 (closed), which described what we want to see from the emails. A corresponding merge request !6019 (merged) is under development for adding the new emails into a new pipeline service. However to make the best experience, we are better off having this integrated into the notification system, rather than a service which people needs to setup for each projects.
#3976 (closed) is already quite long so I would like to have this issue serving as a new thread for having this integrated as part of the notification system. I'll begin investigating how to do this properly.
Designs
An error occurred while loading designs. Please try again.
Child items
0
Show closed items
GraphQL error: The resource that you are attempting to access does not exist or you don't have permission to perform this action
No child items are currently open.
Linked items
0
Link issues together to show that they're related or that one is blocking others.
Learn more.
It seems that it's just NotificationService and it would call Notify. The new email is introduced in !6019 (merged), so we just need to add a method to NotificationService, and that's probably all.
So the question might be more like who we want to notify. Other than pushers who triggered the pipeline, anyone else?
@ayufan What do you think about notification settings for this one? At first I would like to make it default on, and people could turn it off. But I realized that custom notification doesn't work that way:
Custom notification levels are the same as participating levels. With custom notification levels you will also receive notifications for select events. To find out more, check out notification emails.
So that means custom notification could only turn more emails on, rather than turning some emails off. So alternatively, we could make it default off, and people could turn it on with custom notification. But I really think we should enable this by default, and I could see that some people might not want this behaviour. What should we do here? We could also make people being able to subscribe to a pipeline, but I guess we'll do that in the next iteration. Or maybe we could just make it off by default, at least that's what people are using right now, and it would make more sense to have it off if we want to make people subscribe to a pipeline.
How feasible will be to make the custom notification for pipelines and allow to disable it?
Code wise I think it should be easy, just make some special cases. However this would break the design and make the custom notification harder to understand for users. So I am not sure if we should do that.
If you are participating you should receive a notification from all pipelines for MRs you have participated in
Of course, we might not be able to do that until we have proper MR to Pipeline mapping?
Then again, I think @ayufan's definition is probably what people expect. Commenting on a MR shouldn't necessarily start you getting pipeline emails, but pushing up a commit yourself should.
Probably, though I am still a bit worried about being too noisy. If there's a way to unsubscribe themselves would be great. I don't know if this is possible right now, personally I don't unsubscribe anything.