milestone dropdown list broken with certain milestone names
Summary
Certain characters in milestone names cause the milestone dropdown menus to not load properly.
Steps to reproduce
- create a milestone with the name "summer'16" for example
- try to open the milestone dropdown in the issue list
Expected behavior
- the dropdown should show all milestones as usual
Actual behaviour
- the dropdown constantly shows the loading animation
Relevant logs and/or screenshots
Output of checks
Results of GitLab application Check
Checking GitLab Shell ...
GitLab Shell version >= 3.4.0 ? ... OK (3.4.0)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by git:git?
default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ...
1/4 ... ok
1/5 ... ok
1/6 ... ok
1/7 ... ok
1/8 ... ok
1/9 ... ok
1/10 ... ok
1/11 ... ok
1/12 ... ok
1/13 ... ok
1/14 ... ok
1/15 ... ok
1/16 ... ok
1/17 ... ok
1/18 ... ok
1/19 ... ok
1/20 ... ok
1/21 ... ok
1/22 ... ok
14/23 ... ok
14/24 ... ok
14/25 ... ok
12/27 ... ok
12/28 ... ok
12/29 ... ok
1/31 ... ok
11/32 ... ok
12/33 ... ok
11/34 ... ok
11/35 ... ok
14/36 ... ok
11/38 ... ok
1/39 ... ok
11/40 ... ok
16/41 ... ok
16/42 ... ok
3/43 ... ok
11/44 ... ok
13/45 ... ok
14/46 ... ok
22/52 ... ok
23/57 ... ok
11/58 ... ok
13/59 ... ok
11/60 ... ok
17/61 ... ok
13/62 ... ok
2/63 ... ok
11/64 ... ok
11/65 ... ok
27/66 ... ok
27/67 ... ok
27/68 ... ok
11/69 ... ok
3/71 ... ok
13/72 ... ok
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK
Send ping to redis server: OK
gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes
Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Reply by email ...
Reply by email is disabled in config/gitlab.yml
Checking Reply by email ... Finished
Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured with autocrlf=input? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config outdated? ... no
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory setup correctly? ... no
Try fixing it:
sudo chown -R git /var/opt/gitlab/gitlab-rails/uploads
sudo find /var/opt/gitlab/gitlab-rails/uploads -type f -exec chmod 0644 {} \;
sudo find /var/opt/gitlab/gitlab-rails/uploads -type d -not -path /var/opt/gitlab/gitlab-rails/uploads -exec chmod 0700 {} \;
For more information see:
doc/install/installation.md in section "GitLab"
Please fix the error above and rerun the checks.
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
projects have namespace: ...
1/4 ... yes
1/5 ... yes
1/6 ... yes
1/7 ... yes
1/8 ... yes
1/9 ... yes
1/10 ... yes
1/11 ... yes
1/12 ... yes
1/13 ... yes
1/14 ... yes
1/15 ... yes
1/16 ... yes
1/17 ... yes
1/18 ... yes
1/19 ... yes
1/20 ... yes
1/21 ... yes
1/22 ... yes
14/23 ... yes
14/24 ... yes
14/25 ... yes
12/27 ... yes
12/28 ... yes
12/29 ... yes
1/31 ... yes
11/32 ... yes
12/33 ... yes
11/34 ... yes
11/35 ... yes
14/36 ... yes
11/38 ... yes
1/39 ... yes
11/40 ... yes
16/41 ... yes
16/42 ... yes
3/43 ... yes
11/44 ... yes
13/45 ... yes
14/46 ... yes
22/52 ... yes
23/57 ... yes
11/58 ... yes
13/59 ... yes
11/60 ... yes
17/61 ... yes
13/62 ... yes
2/63 ... yes
11/64 ... yes
11/65 ... yes
27/66 ... yes
27/67 ... yes
27/68 ... yes
11/69 ... yes
3/71 ... yes
13/72 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.1.0 ? ... yes (2.3.1)
Your git bin path is "/opt/gitlab/embedded/bin/git"
Git version >= 2.7.3 ? ... yes (2.7.4)
Active users: 21
Checking GitLab ... Finished
Results of GitLab environment info
System information
System: Ubuntu 14.04
Current User: git
Using RVM: no
Ruby Version: 2.3.1p112
Gem Version: 2.6.6
Bundler Version:2.3.0
Rake Version: 10.5.0
Sidekiq Version:4.1.4
GitLab information
Version: 8.11.2
Revision: e618ce2
Directory: /opt/gitlab/embedded/service/gitlab-rails
DB Adapter: postgresql
URL: http://git.kicks-ass.net
HTTP Clone URL: http://git.kicks-ass.net/some-group/some-project.git
SSH Clone URL: git@git.kicks-ass.net:some-group/some-project.git
Using LDAP: no
Using Omniauth: yes
Omniauth Providers: github
GitLab Shell
Version: 3.4.0
Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories
Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks/
Git: /opt/gitlab/embedded/bin/git
Possible fixes
I think its a escape problem if the milestone name string or something