Wrong Tab Selected When Loggin Fails And Multiple Login Tabs Exists

I have LDAP enabled. When I use the "Standard" login method and login fails the LDAP tab is selected. When I click back on the Standard login tab my user name is still filled out.

To reproduce

1. Enable LDAP
2. Go to login page
3. Select standard login method tab
4. Attempt to log in with valid user and incorrect password

Expected behavior

After a login attempt the method you are attempting to log in with (in this case Standard) should be selected and the password field should be focused.

Title changed from Wrong Tab Selected When Loggin In Fails And Multiple Login Tabs Exists to Wrong Tab Selected When Loggin Fails And Multiple Login Tabs Exists

Hi @amayer5125,

First of all, thank you for raising an issue to help improve the GitLab product. We're sorry about this, but this particular issue has gone unnoticed for quite some time. To establish order in the GitLab-CE Issue Tracker, we must ensure that every issue is correctly labelled and triaged, to get the proper attention.

This issue will be closed, as it meets the following criteria:

• No activity in the past 4 months
• Unlabelled
• Unassigned
• It's not associated with a particular milestone

We'd like to ask you to help us out and determine whether this issue should be reopened.

If this issue is reporting a bug, please can you attempt to reproduce on the latest version of GitLab or GitLab.com, to help us to understand whether the bug still needs our attention.

If this issue is proposing a new feature, please can you verify whether the feature proposal is still relevant.

Thanks for your help

Added ~761915 label

Status changed to closed

I just tried this on version 8.12.7 and this problem still exists.

Thank you @amayer5125 ! I can also reproduce this on my own instance. I'll reopen and mark this as a bug

Thanks so much for helping out!

Added ~127616 ~12980 ~131895 and removed ~761915 labels

Status changed to reopened

Mentioned in issue #22412 (closed)

Added ~876590 and removed ~131895 labels

Mentioned in merge request !7195 (closed)

Hello. I've pushed a PR for this issue. The solution that I propose consists in saving into temporary session the last "failure_auth_method" used and showing the correct tab depending on that. Note: This is my first PR so I'd be happy to fix any mistakes I've done in the process.

@jacopo-beschi That's great!

Mentioned in merge request !7314 (merged)

@fatihacet What you think if I also move the class into a file in the asset pipeline so that you can use it if is needed? I mean leave the class instantiation in the signin_tabs_memoizer but make the class gobally available?

closed via merge request !7314 (merged)

mentioned in commit rickettm/gitlab-ce@1413c94a