500 Error when comparing Annotated Tags
Summary
We consistently receive a 500 error whenever we compare tags that are annotated. The issue started occurring after an inline upgrade from GitLab CE 7.9 to v8.4.3 eb6f6917 For example
Steps to reproduce
http://gitlab/ns/project/compare/v1...v2
If tag v1 or v2 is annotated, we receive a 500 error. If we recreate the tags without an annotated message, it works as expected.
Expected behavior
We should see a normal comparison of tagged commits
Relevant logs and/or screenshots
production.log output
Processing by Projects::CompareController#show as HTML
Parameters: {"namespace_id"=>"ns", "project_id"=>"project", "from"=>"v1", "to"=>"v2"}
Completed 500 Internal Server Error in 119ms (ActiveRecord: 12.4ms)
Rugged::InvalidError (Object is no commit object):
app/models/repository.rb:591:in `merge_base'
app/models/repository.rb:591:in `merge_base'
app/models/project.rb:348:in `merge_base_commit'
app/controllers/projects/compare_controller.rb:24:in `show'
Output of checks
Results of GitLab Application Check
Checking GitLab Shell ...
GitLab Shell version >= 2.6.10 ? ... OK (2.6.10)
Repo base directory exists? ... yes
Repo base directory is a symlink? ... no
Repo base owned by git:git? ... yes
Repo base access is drwxrws---? ... yes
hooks directories in repos are links: ...
8/7 ... ok
17/8 ... ok
12/11 ... ok
8/12 ... ok
11/13 ... ok
11/19 ... ok
11/20 ... ok
11/21 ... ok
16/33 ... ok
16/35 ... ok
10/36 ... ok
12/37 ... ok
17/38 ... ok
17/39 ... ok
17/40 ... ok
17/41 ... ok
17/42 ... ok
17/43 ... ok
17/44 ... ok
17/45 ... ok
17/46 ... ok
17/47 ... ok
17/48 ... ok
17/49 ... ok
17/50 ... ok
17/51 ... ok
17/52 ... ok
12/59 ... ok
9/60 ... ok
17/61 ... ok
16/62 ... ok
16/63 ... ok
9/64 ... ok
12/65 ... ok
16/68 ... ok
8/69 ... ok
16/70 ... ok
9/71 ... ok
16/72 ... ok
8/73 ... ok
16/74 ... repository is empty
16/77 ... ok
9/78 ... ok
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Check directories and files:
/var/opt/gitlab/git-data/repositories: OK
/var/opt/gitlab/.ssh/authorized_keys: OK
Test redis-cli executable: redis-cli 2.8.21
Send ping to redis server: PONG
gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes
Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Reply by email ...
Reply by email is disabled in config/gitlab.yml
Checking Reply by email ... Finished
Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured with autocrlf=input? ... yes
Database config exists? ... yes
Database is SQLite ... no
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config outdated? ... no
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory setup correctly? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
projects have namespace: ...
8/7 ... yes
17/8 ... yes
12/11 ... yes
8/12 ... yes
11/13 ... yes
11/19 ... yes
11/20 ... yes
11/21 ... yes
16/33 ... yes
16/35 ... yes
10/36 ... yes
12/37 ... yes
17/38 ... yes
17/39 ... yes
17/40 ... yes
17/41 ... yes
17/42 ... yes
17/43 ... yes
17/44 ... yes
17/45 ... yes
17/46 ... yes
17/47 ... yes
17/48 ... yes
17/49 ... yes
17/50 ... yes
17/51 ... yes
17/52 ... yes
12/59 ... yes
9/60 ... yes
17/61 ... yes
16/62 ... yes
16/63 ... yes
9/64 ... yes
12/65 ... yes
16/68 ... yes
8/69 ... yes
16/70 ... yes
9/71 ... yes
16/72 ... yes
8/73 ... yes
16/74 ... yes
16/77 ... yes
9/78 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.1.0 ? ... yes (2.1.8)
Your git bin path is "/opt/gitlab/embedded/bin/git"
Git version >= 1.7.10 ? ... yes (2.6.2)
Active users: 17
Checking GitLab ... Finished
Results of GitLab Environment Info
System information
System:
Current User: git
Using RVM: no
Ruby Version: 2.1.8p440
Gem Version: 2.5.1
Bundler Version:1.10.6
Rake Version: 10.5.0
Sidekiq Version:4.0.1
GitLab information
Version: 8.4.3
Revision: eb6f691
Directory: /opt/gitlab/embedded/service/gitlab-rails
DB Adapter: postgresql
URL: http://gitlab.roselle.nmi.com
HTTP Clone URL: http://gitlab.roselle.nmi.com/some-group/some-project.git
SSH Clone URL: git@gitlab.roselle.nmi.com:some-group/some-project.git
Using LDAP: no
Using Omniauth: no
GitLab Shell
Version: 2.6.10
Repositories: /var/opt/gitlab/git-data/repositories
Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks/
Git: /opt/gitlab/embedded/bin/git
Possible fixes
n/a