New 'confirm' flag on create user API does not work

Summary

When trying to create a new user using the API with confirm=false, the create fails because the User class has no attribute named "confirm".

Steps to reproduce

Call create user API, eg:

POST "/api/v3/users?password=[FILTERED]&confirm=False&username=rickettm&email=...&name=M.Ricketts&extern_uid=uid&provider=ldapmain"

Expected behaviour: it should work :)

Observed behaviour

Create fails. Production.log has:

ActiveRecord::UnknownAttributeError (unknown attribute: confirm):
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/activerecord-4.1.9/lib/active_record/attribute_assignment.rb:50:in `rescue in _assign_attribute'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/activerecord-4.1.9/lib/active_record/attribute_assignment.rb:45:in `_assign_attribute'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/activerecord-4.1.9/lib/active_record/attribute_assignment.rb:32:in `block in assign_attributes'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/activerecord-4.1.9/lib/active_record/attribute_assignment.rb:26:in `each'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/activerecord-4.1.9/lib/active_record/attribute_assignment.rb:26:in `assign_attributes'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/activerecord-4.1.9/lib/active_record/core.rb:452:in `init_attributes'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/activerecord-4.1.9/lib/active_record/core.rb:195:in `initialize'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/default_value_for-3.0.0/lib/default_value_for.rb:142:in `initialize'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/devise-3.2.4/lib/devise/models/confirmable.rb:47:in `initialize'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/state_machine-1.2.0/lib/state_machine/integrations/active_record.rb:470:in `initialize'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/activerecord-4.1.9/lib/active_record/inheritance.rb:30:in `new'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/activerecord-4.1.9/lib/active_record/inheritance.rb:30:in `new'
  /gitlab/gittest001/gitlab/app/models/user.rb:229:in `build_user'
  /gitlab/gittest001/gitlab/lib/api/users.rb:64:in `block (2 levels) in <class:Users>'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/grape-0.6.1/lib/grape/endpoint.rb:31:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/grape-0.6.1/lib/grape/endpoint.rb:31:in `block in generate_api_method'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/grape-0.6.1/lib/grape/endpoint.rb:401:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/grape-0.6.1/lib/grape/endpoint.rb:401:in `run'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/grape-0.6.1/lib/grape/endpoint.rb:154:in `block in call!'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/grape-0.6.1/lib/grape/middleware/base.rb:24:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/grape-0.6.1/lib/grape/middleware/base.rb:24:in `call!'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/grape-0.6.1/lib/grape/middleware/base.rb:18:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/grape-0.6.1/lib/grape/middleware/base.rb:24:in `call!'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/grape-0.6.1/lib/grape/middleware/base.rb:18:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/rack-oauth2-1.0.8/lib/rack/oauth2/server/resource.rb:20:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/rack-oauth2-1.0.8/lib/rack/oauth2/server/resource/bearer.rb:8:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/grape-0.6.1/lib/grape/middleware/error.rb:26:in `block in call!'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/grape-0.6.1/lib/grape/middleware/error.rb:25:in `catch'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/grape-0.6.1/lib/grape/middleware/error.rb:25:in `call!'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/grape-0.6.1/lib/grape/middleware/base.rb:18:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/rack-1.5.2/lib/rack/head.rb:11:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/rack-1.5.2/lib/rack/builder.rb:138:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/grape-0.6.1/lib/grape/endpoint.rb:155:in `call!'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/grape-0.6.1/lib/grape/endpoint.rb:145:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/rack-mount-0.8.3/lib/rack/mount/route_set.rb:152:in `block in call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/rack-mount-0.8.3/lib/rack/mount/code_generation.rb:96:in `block in recognize'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/rack-mount-0.8.3/lib/rack/mount/code_generation.rb:68:in `optimized_each'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/rack-mount-0.8.3/lib/rack/mount/code_generation.rb:95:in `recognize'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/rack-mount-0.8.3/lib/rack/mount/route_set.rb:141:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/grape-0.6.1/lib/grape/api.rb:525:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/grape-0.6.1/lib/grape/api.rb:42:in `call!'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/grape-0.6.1/lib/grape/api.rb:38:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/actionpack-4.1.9/lib/action_dispatch/journey/router.rb:73:in `block in call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/actionpack-4.1.9/lib/action_dispatch/journey/router.rb:59:in `each'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/actionpack-4.1.9/lib/action_dispatch/journey/router.rb:59:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/actionpack-4.1.9/lib/action_dispatch/routing/route_set.rb:685:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/omniauth-1.1.4/lib/omniauth/strategy.rb:184:in `call!'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/omniauth-1.1.4/lib/omniauth/strategy.rb:164:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/request_store-1.0.5/lib/request_store/middleware.rb:9:in `call'
  /gitlab/gittest001/gitlab/lib/ibm_gitlab.rb:21:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/rack-cors-0.2.9/lib/rack/cors.rb:54:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/rack-attack-4.2.0/lib/rack/attack.rb:104:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/warden-1.2.3/lib/warden/manager.rb:35:in `block in call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/warden-1.2.3/lib/warden/manager.rb:34:in `catch'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/warden-1.2.3/lib/warden/manager.rb:34:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/rack-1.5.2/lib/rack/etag.rb:23:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/rack-1.5.2/lib/rack/conditionalget.rb:35:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/rack-1.5.2/lib/rack/head.rb:11:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/actionpack-4.1.9/lib/action_dispatch/middleware/params_parser.rb:27:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/actionpack-4.1.9/lib/action_dispatch/middleware/flash.rb:254:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/rack-1.5.2/lib/rack/session/abstract/id.rb:225:in `context'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/rack-1.5.2/lib/rack/session/abstract/id.rb:220:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/actionpack-4.1.9/lib/action_dispatch/middleware/cookies.rb:562:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/activerecord-4.1.9/lib/active_record/query_cache.rb:36:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/activerecord-4.1.9/lib/active_record/connection_adapters/abstract/connection_pool.rb:621:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/actionpack-4.1.9/lib/action_dispatch/middleware/callbacks.rb:29:in `block in call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/activesupport-4.1.9/lib/active_support/callbacks.rb:82:in `run_callbacks'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/actionpack-4.1.9/lib/action_dispatch/middleware/callbacks.rb:27:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/actionpack-4.1.9/lib/action_dispatch/middleware/remote_ip.rb:76:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/actionpack-4.1.9/lib/action_dispatch/middleware/debug_exceptions.rb:17:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/actionpack-4.1.9/lib/action_dispatch/middleware/show_exceptions.rb:30:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/railties-4.1.9/lib/rails/rack/logger.rb:38:in `call_app'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/railties-4.1.9/lib/rails/rack/logger.rb:20:in `block in call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/activesupport-4.1.9/lib/active_support/tagged_logging.rb:68:in `block in tagged'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/activesupport-4.1.9/lib/active_support/tagged_logging.rb:26:in `tagged'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/activesupport-4.1.9/lib/active_support/tagged_logging.rb:68:in `tagged'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/railties-4.1.9/lib/rails/rack/logger.rb:20:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/actionpack-4.1.9/lib/action_dispatch/middleware/request_id.rb:21:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/rack-1.5.2/lib/rack/methodoverride.rb:21:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/rack-1.5.2/lib/rack/runtime.rb:17:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/rack-1.5.2/lib/rack/lock.rb:17:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/rack-1.5.2/lib/rack/sendfile.rb:112:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/railties-4.1.9/lib/rails/engine.rb:514:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/railties-4.1.9/lib/rails/application.rb:144:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/railties-4.1.9/lib/rails/railtie.rb:194:in `public_send'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/railties-4.1.9/lib/rails/railtie.rb:194:in `method_missing'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/rack-1.5.2/lib/rack/builder.rb:138:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/rack-1.5.2/lib/rack/urlmap.rb:65:in `block in call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/rack-1.5.2/lib/rack/urlmap.rb:50:in `each'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/rack-1.5.2/lib/rack/urlmap.rb:50:in `call'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/unicorn-4.6.3/lib/unicorn/http_server.rb:552:in `process_client'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/unicorn-worker-killer-0.4.2/lib/unicorn/worker_killer.rb:51:in `process_client'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/unicorn-4.6.3/lib/unicorn/http_server.rb:632:in `worker_loop'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/unicorn-4.6.3/lib/unicorn/http_server.rb:500:in `spawn_missing_workers'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/unicorn-4.6.3/lib/unicorn/http_server.rb:142:in `start'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/gems/unicorn-4.6.3/bin/unicorn_rails:209:in `<top (required)>'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/bin/unicorn_rails:23:in `load'
  /gitlab/gittest001/gitlab/vendor/bundle/ruby/2.1.0/bin/unicorn_rails:23:in `<main>'

Output of checks

Checking Environment ...

Git configured for gittest001 user? ... yes

Checking Environment ... Finished

Checking GitLab Shell ...

GitLab Shell version >= 2.6.0 ? ... OK (2.6.0)
Repo base directory exists? ... yes
Repo base directory is a symlink? ... no
Repo base owned by gittest001:gittest001? ... yes
Repo base access is drwxrws---? ... yes
Satellites access is drwxr-x---? ... yes
hooks directories in repos are links: ... can't check, you have no projects
Running /gitlab/gittest001/gitlab-shell/bin/check
Check GitLab API access: Started GET "/api/v3/internal/check" for 9.20.84.121 at 2015-03-24 16:31:56 +0000
OK
Check directories and files: 
	/gitlab/gittest001/repositories/: OK
	/gitlab/gittest001/.ssh/authorized_keys: OK
Test redis-cli executable: redis-cli 2.4.10
Send ping to redis server: PONG
gitlab-shell self-check successful

Checking GitLab Shell ... Finished

Checking Sidekiq ...

Running? ... yes
Number of Sidekiq processes ... 1

Checking Sidekiq ... Finished

Checking LDAP ...

LDAP users with access to your GitLab server (only showing the first 100 results)
Server: ldapmain
    <snipped>
Checking LDAP ... Finished

Checking GitLab ...

Database config exists? ... yes
Database is SQLite ... no
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config outdated? ... no
Log directory writable? ... yes
Tmp directory writable? ... yes
Init script exists? ... no
  Try fixing it:
  Install the init script
  For more information see:
  doc/install/installation.md in section "Install Init Script"
  Please fix the error above and rerun the checks.
Init script up-to-date? ... can't check because of previous errors
projects have namespace: ... can't check, you have no projects
Projects have satellites? ... can't check, you have no projects
Redis version >= 2.0.0? ... yes
Ruby version >= 2.0.0 ? ... yes (2.1.2)
Your git bin path is "/usr/bin/git"
Git version >= 1.7.10 ? ... yes (1.8.3)
Active users: 2

Checking GitLab ... Finished

The missing initscript error is a red herring and not related to this issue

GitLab version: GitLab 7.9.0 16d6f0e3

$ bundle exec rake gitlab:env:info RAILS_ENV=production

System information
System:		
Current User:	gittest001
Using RVM:	no
Ruby Version:	2.1.2p95
Gem Version:	2.2.2
Bundler Version:1.8.3
Rake Version:	10.4.2
Sidekiq Version:3.3.0

GitLab information
Version:	7.9.0
Revision:	16d6f0e
Directory:	/gitlab/gittest001/gitlab
DB Adapter:	postgresql
URL:		https://gittest001.hursley.ibm.com
HTTP Clone URL:	https://gittest001.hursley.ibm.com/some-project.git
SSH Clone URL:	gittest001@gittest001.hursley.ibm.com:some-project.git
Using LDAP:	yes
Using Omniauth:	no

GitLab Shell
Version:	2.6.0
Repositories:	/gitlab/gittest001/repositories/
Hooks:		/gitlab/gittest001/gitlab-shell/hooks/
Git:		/usr/bin/git

Possible fixes

I think the error is caused by the ordering of things in lib/api/users.py As User.build_user() does not accept the 'confirm' attribute it needs to be removed before the call