omniauth import from gitlab.com fails
on my new Ubuntu 14.04 omnibus install of GL 8.4 importing a repo from GL.com fails.
This is the error I get:
2016-01-23_11:44:24.42565 2016-01-23T11:44:24.424Z 2583 TID-amb1g RepositoryImportWorker JID-8c6d22ddebe6f907def9df6e INFO: start
2016-01-23_11:44:38.25054 2016-01-23T11:44:38.250Z 2583 TID-amb1g RepositoryImportWorker JID-8c6d22ddebe6f907def9df6e INFO: fail: 13.825 sec
2016-01-23_11:44:38.25078 2016-01-23T11:44:38.250Z 2583 TID-amb1g WARN: {"class"=>"RepositoryImportWorker", "args"=>[9], "retry"=>true, "queue"=>"gitlab_shell", "jid"=>"8c6d22ddebe6f907def9df6e", "created_at"=>1453549464.4242156, "enqueued_at"=>1453549464.4243178, "error_message"=>"wrong number of arguments (2 for 1)", "error_class"=>"ArgumentError", "failed_at"=>1453549478.249842, "retry_count"=>0}
2016-01-23_11:44:38.25086 2016-01-23T11:44:38.250Z 2583 TID-amb1g WARN: ArgumentError: wrong number of arguments (2 for 1)
2016-01-23_11:44:38.25094 2016-01-23T11:44:38.250Z 2583 TID-amb1g WARN: /opt/gitlab/embedded/lib/ruby/2.1.0/cgi/util.rb:7:in `escape'
2016-01-23_11:44:38.25095 /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/gitlab_import/importer.rb:15:in `execute'
This seems to be the replace or URI.decode to CGI.escape. see commit: https://gitlab.com/gitlab-org/gitlab-ce/commit/932a247f5fb4a14b3e096ec88a73f8fce481eebb
edit: After patching this on my machine the import works fine.
According to the RubyDocs, CGI.escape can only take 1 argument where URI.decode can take an optional second argument.