Skip to content
Snippets Groups Projects
  1. May 07, 2019
  2. Apr 23, 2019
  3. Apr 12, 2019
  4. Apr 05, 2019
    • Gosia Ksionek's avatar
      Add part of needed code · 64858317
      Gosia Ksionek authored and Douglas Barbosa Alexandre's avatar Douglas Barbosa Alexandre committed
      Add columns to store project creation settings
      
      Add project creation level column in groups
       and default project creation column in application settings
      
      Remove obsolete line from schema
      
      Update migration with project_creation_level column existence check
      
      Rename migrations to avoid conflicts
      
      Update migration methods
      
      Update migration method
      64858317
    • Brandon Labuschagne's avatar
      Add limit of 128 characters to users name · ebfe19e8
      Brandon Labuschagne authored
      Truncate existing users names which exceed 128 characters
      Include test for truncating users names
      ebfe19e8
  5. Mar 28, 2019
  6. Mar 22, 2019
  7. Mar 06, 2019
  8. Mar 05, 2019
  9. Feb 19, 2019
    • Stan Hu's avatar
      Make Admin::UsersController work with Ruby 2.6 · e87c255d
      Stan Hu authored
      Ruby 2.6 introduced `Enumerable#filter`, which takes no arguments.
      Attempting to call `filter` on an `ActiveRecord::Relation` with a scope
      will fail with a `wrong number of arguments (given 1, expected 0)`
      message because the `Enumerable#filter` implementation overrides the
      delegated `ActiveRecord::Relation#filter` method.
      
      To make Admin::UsersController compatible with Ruby 2.6, rename
      `User.filter` to `User.filter_items`.
      e87c255d
  10. Feb 13, 2019
    • Luke Bennett's avatar
      Improve the GitHub and Gitea import feature table interface · 534a6117
      Luke Bennett authored
      These are backend changes.
      Use Vue for the import feature UI for "githubish"
      providers (GitHub and Gitea).
      Add "Go to project" button after a successful import.
      Use CI-style status icons and improve spacing of the
      table and its component.
      Adds ETag polling to the github and gitea import
      jobs endpoint.
      Verified
      534a6117
  11. Feb 08, 2019
  12. Feb 06, 2019
  13. Feb 05, 2019
    • Brandon Labuschagne's avatar
      Add last activity to user administration · d279cc94
      Brandon Labuschagne authored
      The columns 'Created on' and 'Last activity' have been
      added to the admin -> users view.
      
      Sorting options have also been added for last activity
      and the search bar has been moved to match the issues
      page.
      d279cc94
  14. Jan 31, 2019
  15. Jan 24, 2019
  16. Jan 21, 2019
  17. Jan 15, 2019
  18. Dec 19, 2018
  19. Dec 13, 2018
  20. Nov 26, 2018
  21. Nov 19, 2018
  22. Nov 07, 2018
    • Tiago Botelho's avatar
      User can keep their commit email private · c239452b
      Tiago Botelho authored
      The private commit email is automatically generated in the format:
      id-username@noreply.HOSTNAME
      
      GitLab instance admins are able to change the HOSTNAME portion,
      that defaults to Gitlab's hostname, to whatever they prefer.
      Unverified
      c239452b
  23. Nov 05, 2018
  24. Nov 01, 2018
  25. Oct 29, 2018
  26. Oct 26, 2018
  27. Oct 23, 2018
  28. Oct 18, 2018
  29. Oct 12, 2018
  30. Oct 08, 2018
    • Yorick Peterse's avatar
      Clean up ActiveRecord code in TodoService · 38b8ae64
      Yorick Peterse authored
      This refactors the TodoService class according to our code reuse
      guidelines. The resulting code is a wee bit more verbose, but it allows
      us to decouple the column names from the input, resulting in fewer
      changes being necessary when we change the schema.
      
      One particular noteworthy line in TodoService is the following:
      
          todos_ids = todos.update_state(state)
      
      Technically this is a violation of the guidelines, because
      `update_state` is a class method, which services are not supposed to use
      (safe for a few allowed ones). I decided to keep this, since there is no
      alternative. `update_state` doesn't produce a relation so it doesn't
      belong in a Finder, and we can't move it to another Service either. As
      such I opted to just use the method directly.
      
      Cases like this may happen more frequently, at which point we should
      update our documentation with some sort of recommendation. For now, I
      want to refrain from doing so until we have a few more examples.
      Verified
      38b8ae64
  31. Sep 24, 2018
  32. Sep 17, 2018
    • Brett Walker's avatar
      Filter out archived projects from issue/mr count · 50a62b47
      Brett Walker authored
      Pass the 'non_archived' flag to finder methods
      50a62b47
    • Yorick Peterse's avatar
      Added FromUnion to easily select from a UNION · 8a72f5c4
      Yorick Peterse authored
      This commit adds the module `FromUnion`, which provides the class method
      `from_union`. This simplifies the process of selecting data from the
      result of a UNION, and reduces the likelihood of making mistakes. As a
      result, instead of this:
      
          union = Gitlab::SQL::Union.new([foo, bar])
      
          Foo.from("(#{union.to_sql}) #{Foo.table_name}")
      
      We can now write this instead:
      
          Foo.from_union([foo, bar])
      
      This commit also includes some changes to make this new setup work
      properly. For example, a bug in Rails 4
      (https://github.com/rails/rails/issues/24193) would break the use of
      `from("sub-query-here").includes(:relation)` in certain cases. There was
      also a CI query which appeared to repeat a lot of conditions from an
      outer query on an inner query, which isn't necessary.
      
      Finally, we include a RuboCop cop to ensure developers use this new
      module, instead of using Gitlab::SQL::Union directly.
      
      Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/51307
      Verified
      8a72f5c4
  33. Sep 16, 2018
Loading