The Google GPG key used to sign the apt repository expired today, so all
installs will fail unless `--allow-unauthenticated` is used. We should
revert this once the repository has been updated with the more recent
key.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60441

Sanad Liaquat authored 5 years ago and Luke Bennett committed 5 years ago

Additionally fixes geo rename test.

Signed-off-by: Rémy Coutable <remy@rymai.me>

Sanad Liaquat authored 5 years ago and Sean McGivern committed 5 years ago

In both e2e QA tests and unit tests, reduce the number of retires
to 2 (i.e., 1 initial and one retry)

The current value cannot be masked[1] but CI variables default to
masked. Rather than implementing a toggle for the masking control,
simply change the value to something that can be masked.

[1] Currently, "simple" values can be masked:
* it should be a single line
* it should not have escape characters
* it should not use variables
* it should not have any whitespace
* it should be longer than 8 characters

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25476

Backports https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10161
(code out of ee/ folder).

Walmyr authored 5 years ago and Mark Lapierre committed 5 years ago

Instead of having a comment describing what a specific value is,
better to have a variable with a meaningful name.

- Update qa selector
- Update PO file

Update QA selector to specify that API URL
is a input type=url field

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/59645.

Don't try to re-create master as a new branch.
Expect a Git error raised when the file it too large.

Walmyr authored 5 years ago and Rémy Coutable committed 5 years ago

This MR addresses the following issue:
https://gitlab.com/gitlab-org/gitlab-ce/issues/57043
Based on the following comment:
https://gitlab.com/gitlab-org/gitlab-ce/issues/57043#note_136663994

Mark Lapierre authored 5 years ago and Rémy Coutable committed 5 years ago

gitlab-qa accepts an env var named GITLAB_QA_ACCESS_TOKEN, but here we
only accepted PERSONAL_ACCESS_TOKEN.

This change replaces PERSONAL_ACCESS_TOKEN with GITLAB_QA_ACCESS_TOKEN

Mark Lapierre authored 5 years ago and Dan Davison committed 5 years ago

First attempt at allowing a feature flag to be set via the command line
when running tests. This will enable the flag, run the tests, and then
disable the flag.

Using OptionParser meant changing how scenarios get the instance
address, so this also allows the address to be set as a command line
option. It's backwards compatible (you can still provide the address
as the command line option after the scenario)

Dan Davison authored 5 years ago and Mark Lapierre committed 5 years ago

The smoke test for AutoDevOps was previously failing.
This test is now passing and ready to be unquarantined

Also update arrivalRate to a max of 100

Walmyr authored 5 years ago and Mark Lapierre committed 5 years ago

Also, make both `it` statments part of the same `describe`.

Finally, remove duplication of strings by defining variables and
re-using them.

The code should be written like a newspaper, wherein the top we
have more high level information, and as we go down we have more
details.

So I'm moving the implementation details to the bottom to make the
test easier to read.

Dylan Griffith authored 5 years ago and Dan Davison committed 5 years ago

The banner is no longer being shown for empty repos since
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26024 . We
could have made this assertion after pushing the repo but this is
not the thing that really needs to be in an integration or smoke test
as it is already tested in
spec/.../projects/show/user_interacts_with_auto_devops_banner_spec

Also add rake tasks that makes use of existing performance data
genertion task.

Walmyr authored 5 years ago and Mark Lapierre committed 5 years ago

... page objects.

Also, update the affected test case.

I choose `click_...` instead of `go_to_...` since it describes
better what the method really does, which is clicking on something.

I know there are other places in the code where methods start with
`click_` and others where methods start with `go_to_`, with that
I'd like to start a discussion or be pointed to the right issue if
there is already one so that we can address this in the whole
framework.
This contribution could be the start in the direction of using the
standard chosen here.

Roman Verevkin authored 6 years ago and Roman Verevkin committed 5 years ago

Add "smoke" tag to the test

Fix links to views in Page Object files

Review fixes

Remove useless view block

Implement Snippets::Show page object class

Fix review suggestions

Fix review suggestions 2

Fix test with empty snippets state

Remove useless css class

Fix issues

The test was previously split into two specs
Having one spec with shared functionality seems
more efficient

Add job checks before the second push is made

Revert "Add job checks before the second push is made"

This reverts commit 64be444cd9d00f2f36eef6dd8a57b464bddbc4ef.

Mark Lapierre authored 5 years ago and Rémy Coutable committed 5 years ago

This avoids running before/after blocks for tests that are in quarantine