- Sep 05, 2019
-
-
Thomas Randolph authored
Basic Intent: Allow all branch names without accidentally creating layout or backstage DOM. e.g. a branch named `separator` should never create a separator `li` element. Ideally, there should never be a string that could cause this kind of conflict. Implementation: All of `GitLabDropdown.renderItem` is extracted to a standalone module. To render a divider or separator, consumers must now pass in an object like `{ "type": "divider" }` or `{ "type": "separator" }` Notable choices: - All of the functions have a cyclomatic complexity of 3 or less - See: https://en.wikipedia.org/wiki/Cyclomatic_complexity - Note the "Correlation to number of defects" section - While software complexity may not have a directly causal relationship with defects, less complex software is generally easier to reason about, and **may** reduce defects. I personally try to maintain complexity of no higher than 3.
-
Sanad Liaquat authored
Split tests across files for the sake of parallelization See merge request gitlab-org/gitlab-ce!32686
-
-
Evan Read authored
Docs: Add role level note to projects permission See merge request gitlab-org/gitlab-ce!32483
-
-
Evan Read authored
Separate doc for version specific Geo update steps Closes gitlab-ee#11881 See merge request gitlab-org/gitlab-ce!32542
-
To emphasize the happy path for updating Geo nodes, put the version specific steps in a separate document and cross-link them for discoverability. Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11881
-
Ash McKenzie authored
What to avoid in code review See merge request gitlab-org/gitlab-ce!32592
-
- Sep 04, 2019
-
-
Mayra Cabrera authored
Bring method back that was mistakenly removed See merge request gitlab-org/gitlab-ce!32667
-
- We're also improving specs to avoid this could happen again
-
Mayra Cabrera authored
Upgrade GraphQL gem to 1.9.11 See merge request gitlab-org/gitlab-ce!31980
-
- `edge_nodes` needs to get called on the object - added `include GlobalID::Identification` in a couple places - renamed `object` to `item` in spec due to conflict
-
Paul Slaughter authored
Merge branch '12155-update-pipelines-minutes-expiry-banner-to-an-alert-component-type-ce' into 'master' CE - Update pipelines minutes expiry banner to an alert component type See merge request gitlab-org/gitlab-ce!31654
-
- remove hiding the alert functionality - use `danger` class instead of `warning` https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14786
-
Mayra Cabrera authored
Merge branch '64009-show-a-meaningful-error-message-when-due-quick_actions-command-fails-because-the-date-format-is-invalid' into 'master' Resolve "Show a meaningful error message when /due quick_actions command fails because the date format is invalid" See merge request gitlab-org/gitlab-ce!32349
-
When using /due quick action with an invalid date a meaninful error message is shown.
-
Mayra Cabrera authored
Create partial index for gitlab-monitor CI metrics See merge request gitlab-org/gitlab-ce!32546
-
Mayra Cabrera authored
Stricter validation of prometheus label values See merge request gitlab-org/gitlab-ce!32460
-
Achilleas Pipinellis authored
Update Pipeline Security Dashboard documentation See merge request gitlab-org/gitlab-ce!32396
-
Achilleas Pipinellis authored
SSoT for API template docs Closes #64589 See merge request gitlab-org/gitlab-ce!31320
-
These docs are straightforward API reference material and needed only to have document type header and troubleshooting footer added for the SSoT effort.
-
Mayra Cabrera authored
Remove unnecessary freeze in app See merge request gitlab-org/gitlab-ce!32636
-
-
Achilleas Pipinellis authored
Adds docs for total usage storage quota See merge request gitlab-org/gitlab-ce!32600
-
-
Mayra Cabrera authored
Upgrade GraphQL gem to 1.8.17 See merge request gitlab-org/gitlab-ce!32299
-
- Due to https://github.com/exAspArk/batch-loader/pull/32, we changed BatchLoader.for into BatchLoader::GraphQL.for - since our results are wrapped in a BatchLoader::GraphQL, calling `sync` during authorization is required to get real object - `graphql` now has it's own authorization system. Our `authorized?` method conflicted and required renaming
-
Clement Ho authored
Add markdownlint-cli to yarn dependencies See merge request gitlab-org/gitlab-ce!32593
-
This is the tool that we use to lint the Markdown files. Let's add it to yarn.lock so that we can use it in development. Pinned to 0.18.0.
-
Mike Greiling authored
Update eslint-utils to 1.4.2 Fixes vulnerability in development environment. See https://nvd.nist.gov/vuln/detail/CVE-2019-15657 See merge request gitlab-org/gitlab-ce!32251
-
Stan Hu authored
Avoid calling freeze on already frozen strings in app/finders See merge request gitlab-org/gitlab-ce!32634
-
Mike Greiling authored
Add ability to see project deployments at cluster level (FE) See merge request gitlab-org/gitlab-ce!31575
-
Added the ability to see project deployments using a group cluster
-
Mike Kozono authored
Let project reporters create issue from group boards Closes #54042 See merge request gitlab-org/gitlab-ce!29866
-
The current state of group issue boards does not show the "Add issues" button on the UI for users that are reporters of group child projects.
-
Mike Kozono authored
Merge branch '60372-milestone-link-prevent-delete-issue-after-move-it-to-another-project-2' into 'master' Add service to transfer Group Milestones when transferring a Project See merge request gitlab-org/gitlab-ce!31778
-
- Add new service that transfers milestones from a group to a project - Include new service in Projects transfer service - Include FromUnion module in Milestone model to use in transfer service - Add specs for new milestones service - Add specs for transferring milestones in project transfer service
-
Rémy Coutable authored
Use spec_helper for S/MIME settings specs See merge request gitlab-org/gitlab-ce!32647
-