-
- Downloads
Clean up CarrierWave's import/export files
Unlike uploads that have been uploaded with Tempfile, the project import/export archives are stored in a temporary cache directory and remain there if: 1. Object storage is enabled 2. `move_to_store` is set to `true`. CarrierWave will leave these files there until disk space runs out or a clean step is run manually. If `move_to_store` is set to `false`, CarrierWave will remove the files after storing them. However, unlike a local file, with object storage, the file is still copied, so setting `move_to_store` to `true` doesn't buy us anything. To ensure files are cleaned up, we can just inherit from the GitlabUploader implementation of `move_to_store`, which returns `true` if it's a local file, `false` otherwise. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60656
parent
bd73925b
No related branches found
No related tags found
Pipeline #60101288 failed
Stage: build
Stage: prepare
Stage: test
Stage: review
Stage: qa
Stage: post-test
Stage: post-cleanup
Showing
- app/uploaders/import_export_uploader.rb 0 additions, 4 deletionsapp/uploaders/import_export_uploader.rb
- changelogs/unreleased/sh-cleanup-import-export.yml 5 additions, 0 deletionschangelogs/unreleased/sh-cleanup-import-export.yml
- spec/uploaders/import_export_uploader_spec.rb 32 additions, 0 deletionsspec/uploaders/import_export_uploader_spec.rb
Please register or sign in to comment