Add latest changes from gitlab-org/gitlab@master

.rubocop_todo/gitlab/bounded_contexts.yml

@@ -1126,9 +1126,9 @@ Gitlab/BoundedContexts:
     - 'app/models/preloaders/environments/deployment_preloader.rb'
     - 'app/models/preloaders/group_policy_preloader.rb'
     - 'app/models/preloaders/group_root_ancestor_preloader.rb'
-    - 'app/models/preloaders/namespace_root_ancestor_preloader.rb'
     - 'app/models/preloaders/labels_preloader.rb'
     - 'app/models/preloaders/merge_request_diff_preloader.rb'
+    - 'app/models/preloaders/namespace_root_ancestor_preloader.rb'
     - 'app/models/preloaders/project_policy_preloader.rb'
     - 'app/models/preloaders/project_root_ancestor_preloader.rb'
     - 'app/models/preloaders/projects/notes_preloader.rb'

.rubocop_todo/graphql/extract_type.yml

@@ -88,7 +88,6 @@ GraphQL/ExtractType:
     - 'ee/app/graphql/types/incident_management/oncall_participant_type.rb'
     - 'ee/app/graphql/types/instance_security_dashboard_type.rb'
     - 'ee/app/graphql/types/iteration_type.rb'
-    - 'ee/app/graphql/types/member_roles/customizable_permission_type.rb'
     - 'ee/app/graphql/types/metric_image_type.rb'
     - 'ee/app/graphql/types/pipeline_security_report_finding_type.rb'
     - 'ee/app/graphql/types/requirements_management/requirement_type.rb'

.rubocop_todo/layout/class_structure.yml

@@ -69,14 +69,10 @@ Layout/ClassStructure:
     - 'app/models/integrations/buildkite.rb'
     - 'app/models/integrations/datadog.rb'
     - 'app/models/integrations/drone_ci.rb'
-    - 'app/models/integrations/external_wiki.rb'
     - 'app/models/integrations/gitlab_slack_application.rb'
-    - 'app/models/integrations/hangouts_chat.rb'
     - 'app/models/integrations/jenkins.rb'
     - 'app/models/integrations/jira.rb'
     - 'app/models/integrations/mattermost.rb'
-    - 'app/models/integrations/microsoft_teams.rb'
-    - 'app/models/integrations/pipelines_email.rb'
     - 'app/models/integrations/prometheus.rb'
     - 'app/models/integrations/zentao.rb'
     - 'app/models/issue.rb'

.rubocop_todo/layout/line_end_string_concatenation_indentation.yml

@@ -12,7 +12,6 @@ Layout/LineEndStringConcatenationIndentation:
     - 'app/models/concerns/spammable.rb'
     - 'app/models/concerns/taskable.rb'
     - 'app/models/integrations/gitlab_slack_application.rb'
-    - 'app/models/integrations/hangouts_chat.rb'
     - 'app/models/integrations/jira.rb'
     - 'app/models/work_items/parent_link.rb'
     - 'app/serializers/import/github_failure_entity.rb'

.rubocop_todo/layout/line_length.yml

@@ -128,8 +128,6 @@ Layout/LineLength:
     - 'app/models/integrations/datadog.rb'
     - 'app/models/integrations/drone_ci.rb'
     - 'app/models/integrations/jenkins.rb'
-    - 'app/models/integrations/microsoft_teams.rb'
-    - 'app/models/integrations/pipelines_email.rb'
     - 'app/models/integrations/prometheus.rb'
     - 'app/models/integrations/zentao.rb'
     - 'app/models/internal_id.rb'
@@ -400,7 +398,6 @@ Layout/LineLength:
     - 'config/initializers/validate_database_config.rb'
     - 'config/initializers/validate_puma.rb'
     - 'config/initializers/zz_metrics.rb'
-    - 'config/puma.rb'
     - 'config/routes.rb'
     - 'config/routes/admin.rb'
     - 'config/routes/group.rb'
@@ -3787,7 +3784,6 @@ Layout/LineLength:
     - 'spec/services/ci/create_pipeline_service/creation_errors_and_warnings_spec.rb'
     - 'spec/services/ci/create_pipeline_service/custom_config_content_spec.rb'
     - 'spec/services/ci/create_pipeline_service/rules_spec.rb'
-    - 'spec/services/ci/create_pipeline_service/tags_spec.rb'
     - 'spec/services/ci/create_pipeline_service_spec.rb'
     - 'spec/services/ci/daily_build_group_report_result_service_spec.rb'
     - 'spec/services/ci/expire_pipeline_cache_service_spec.rb'

.rubocop_todo/lint/unused_block_argument.yml

@@ -157,7 +157,6 @@ Lint/UnusedBlockArgument:
     - 'lib/api/entities/ml/mlflow/run_info.rb'
     - 'lib/api/entities/note.rb'
     - 'lib/api/entities/project.rb'
-    - 'lib/api/entities/project_integration.rb'
     - 'lib/api/entities/project_label.rb'
     - 'lib/api/entities/projects/topic.rb'
     - 'lib/api/entities/public_group_details.rb'

.rubocop_todo/lint/unused_method_argument.yml

@@ -104,7 +104,6 @@ Lint/UnusedMethodArgument:
     - 'app/models/external_issue.rb'
     - 'app/models/group.rb'
     - 'app/models/integrations/buildkite.rb'
-    - 'app/models/integrations/microsoft_teams.rb'
     - 'app/models/integrations/prometheus.rb'
     - 'app/models/internal_id.rb'
     - 'app/models/issue.rb'

.rubocop_todo/rspec/any_instance_of.yml

@@ -261,7 +261,6 @@ RSpec/AnyInstanceOf:
     - 'spec/services/projects/update_service_spec.rb'
     - 'spec/services/projects/update_statistics_service_spec.rb'
     - 'spec/services/snippets/create_service_spec.rb'
-    - 'spec/services/todo_service_spec.rb'
     - 'spec/services/users/destroy_service_spec.rb'
     - 'spec/spec_helper.rb'
     - 'spec/support/capybara.rb'

.rubocop_todo/rspec/be_eq.yml

@@ -702,7 +702,6 @@ RSpec/BeEq:
     - 'spec/lib/cloud_connector/connected_service_spec.rb'
     - 'spec/lib/constraints/jira_encoded_url_constrainer_spec.rb'
     - 'spec/lib/container_registry/gitlab_api_client_spec.rb'
-    - 'spec/lib/container_registry/tag_spec.rb'
     - 'spec/lib/event_filter_spec.rb'
     - 'spec/lib/extracts_path_spec.rb'
     - 'spec/lib/extracts_ref/ref_extractor_spec.rb'

.rubocop_todo/rspec/be_nil.yml

@@ -95,7 +95,6 @@ RSpec/BeNil:
     - 'spec/services/alert_management/alerts/todo/create_service_spec.rb'
     - 'spec/services/groups/transfer_service_spec.rb'
     - 'spec/services/merge_requests/merge_service_spec.rb'
-    - 'spec/services/packages/maven/create_package_service_spec.rb'
     - 'spec/services/packages/ml_model/create_package_file_service_spec.rb'
     - 'spec/services/packages/npm/generate_metadata_service_spec.rb'
     - 'spec/services/projects/create_from_template_service_spec.rb'

.rubocop_todo/rspec/before_all_role_assignment.yml

@@ -981,7 +981,6 @@ RSpec/BeforeAllRoleAssignment:
     - 'spec/models/concerns/loaded_in_group_list_spec.rb'
     - 'spec/models/event_spec.rb'
     - 'spec/models/group_spec.rb'
-    - 'spec/models/integrations/microsoft_teams_spec.rb'
     - 'spec/models/issue_spec.rb'
     - 'spec/models/members/group_member_spec.rb'
     - 'spec/models/members/project_member_spec.rb'

.rubocop_todo/rspec/context_wording.yml

@@ -1422,7 +1422,6 @@ RSpec/ContextWording:
     - 'spec/lib/constraints/project_url_constrainer_spec.rb'
     - 'spec/lib/constraints/user_url_constrainer_spec.rb'
     - 'spec/lib/container_registry/registry_spec.rb'
-    - 'spec/lib/container_registry/tag_spec.rb'
     - 'spec/lib/error_tracking/sentry_client/projects_spec.rb'
     - 'spec/lib/expand_variables_spec.rb'
     - 'spec/lib/extracts_path_spec.rb'
@@ -1977,11 +1976,8 @@ RSpec/ContextWording:
     - 'spec/models/integrations/datadog_spec.rb'
     - 'spec/models/integrations/drone_ci_spec.rb'
     - 'spec/models/integrations/every_integration_spec.rb'
-    - 'spec/models/integrations/external_wiki_spec.rb'
     - 'spec/models/integrations/jenkins_spec.rb'
     - 'spec/models/integrations/jira_spec.rb'
-    - 'spec/models/integrations/microsoft_teams_spec.rb'
-    - 'spec/models/integrations/pipelines_email_spec.rb'
     - 'spec/models/integrations/prometheus_spec.rb'
     - 'spec/models/internal_id_spec.rb'
     - 'spec/models/issue/metrics_spec.rb'

.rubocop_todo/rspec/example_without_description.yml

@@ -377,7 +377,6 @@ RSpec/ExampleWithoutDescription:
     - 'spec/lib/sbom/package_url/decoder_spec.rb'
     - 'spec/lib/sbom/package_url_spec.rb'
     - 'spec/lib/system_check/app/redis_version_check_spec.rb'
-    - 'spec/lib/web_ide/extensions_marketplace_spec.rb'
     - 'spec/mailers/emails/profile_spec.rb'
     - 'spec/mailers/previews_spec.rb'
     - 'spec/migrations/db/migrate/20240806100120_remove_records_without_project_from_project_saved_replies_table_spec.rb'

.rubocop_todo/rspec/excessive_docstring_spacing.yml

@@ -59,7 +59,6 @@ RSpec/ExcessiveDocstringSpacing:
     - 'spec/models/concerns/deployment_platform_spec.rb'
     - 'spec/models/concerns/discussion_on_diff_spec.rb'
     - 'spec/models/identity_spec.rb'
-    - 'spec/models/integrations/pipelines_email_spec.rb'
     - 'spec/models/merge_request_spec.rb'
     - 'spec/models/namespaces/randomized_suffix_path_spec.rb'
     - 'spec/models/repository_spec.rb'

.rubocop_todo/rspec/factory_bot/avoid_create.yml

@@ -133,6 +133,7 @@ RSpec/FactoryBot/AvoidCreate:
     - 'ee/spec/serializers/ee/issue_sidebar_basic_entity_spec.rb'
     - 'ee/spec/serializers/ee/issue_sidebar_extras_entity_spec.rb'
     - 'ee/spec/serializers/ee/merge_request_poll_cached_widget_entity_spec.rb'
+    - 'ee/spec/serializers/ee/merge_request_poll_widget_entity_spec.rb'
     - 'ee/spec/serializers/ee/note_entity_spec.rb'
     - 'ee/spec/serializers/ee/user_serializer_spec.rb'
     - 'ee/spec/serializers/environment_entity_spec.rb'
@@ -154,7 +155,6 @@ RSpec/FactoryBot/AvoidCreate:
     - 'ee/spec/serializers/linked_feature_flag_issue_entity_spec.rb'
     - 'ee/spec/serializers/member_entity_spec.rb'
     - 'ee/spec/serializers/member_user_entity_spec.rb'
-    - 'ee/spec/serializers/merge_request_poll_widget_entity_spec.rb'
     - 'ee/spec/serializers/merge_request_widget_entity_spec.rb'
     - 'ee/spec/serializers/pipeline_serializer_spec.rb'
     - 'ee/spec/serializers/productivity_analytics_merge_request_entity_spec.rb'

.rubocop_todo/rspec/feature_category.yml

@@ -3203,7 +3203,6 @@ RSpec/FeatureCategory:
     - 'spec/models/concerns/discussion_on_diff_spec.rb'
     - 'spec/models/concerns/each_batch_spec.rb'
     - 'spec/models/concerns/editable_spec.rb'
-    - 'spec/models/concerns/encrypted_user_password_spec.rb'
     - 'spec/models/concerns/expirable_spec.rb'
     - 'spec/models/concerns/faster_cache_keys_spec.rb'
     - 'spec/models/concerns/featurable_spec.rb'
@@ -3659,7 +3658,6 @@ RSpec/FeatureCategory:
     - 'spec/rubocop/cop/usage_data/instrumentation_superclass_spec.rb'
     - 'spec/rubocop/cop/usage_data/large_table_spec.rb'
     - 'spec/rubocop/cop/user_admin_spec.rb'
-    - 'spec/rubocop/formatter/graceful_formatter_spec.rb'
     - 'spec/rubocop/migration_helpers_spec.rb'
     - 'spec/rubocop/qa_helpers_spec.rb'
     - 'spec/rubocop/todo_dir_spec.rb'
@@ -3852,7 +3850,6 @@ RSpec/FeatureCategory:
     - 'spec/tasks/gitlab/uploads/migrate_rake_spec.rb'
     - 'spec/tasks/gitlab/x509/update_rake_spec.rb'
     - 'spec/tasks/migrate/schema_check_rake_spec.rb'
-    - 'spec/tasks/rubocop_rake_spec.rb'
     - 'spec/tasks/tokens_rake_spec.rb'
     - 'spec/tooling/danger/config_files_spec.rb'
     - 'spec/tooling/danger/customer_success_spec.rb'

.rubocop_todo/rspec/named_subject.yml

@@ -1575,7 +1575,6 @@ RSpec/NamedSubject:
     - 'spec/lib/container_registry/gitlab_api_client_spec.rb'
     - 'spec/lib/container_registry/path_spec.rb'
     - 'spec/lib/container_registry/registry_spec.rb'
-    - 'spec/lib/container_registry/tag_spec.rb'
     - 'spec/lib/error_tracking/sentry_client/event_spec.rb'
     - 'spec/lib/error_tracking/sentry_client/issue_spec.rb'
     - 'spec/lib/error_tracking/sentry_client/projects_spec.rb'
@@ -2461,12 +2460,10 @@ RSpec/NamedSubject:
     - 'spec/models/integrations/chat_message/push_message_spec.rb'
     - 'spec/models/integrations/chat_message/wiki_page_message_spec.rb'
     - 'spec/models/integrations/drone_ci_spec.rb'
-    - 'spec/models/integrations/external_wiki_spec.rb'
     - 'spec/models/integrations/gitlab_slack_application_spec.rb'
     - 'spec/models/integrations/google_play_spec.rb'
     - 'spec/models/integrations/jenkins_spec.rb'
     - 'spec/models/integrations/matrix_spec.rb'
-    - 'spec/models/integrations/pipelines_email_spec.rb'
     - 'spec/models/integrations/squash_tm_spec.rb'
     - 'spec/models/integrations/telegram_spec.rb'
     - 'spec/models/integrations/zentao_spec.rb'

.rubocop_todo/rspec/no_expectation_example.yml

@@ -125,7 +125,6 @@ RSpec/NoExpectationExample:
     - 'spec/models/ci/pipeline_spec.rb'
     - 'spec/models/deploy_key_spec.rb'
     - 'spec/models/group_spec.rb'
-    - 'spec/models/integrations/pipelines_email_spec.rb'
     - 'spec/models/remote_mirror_spec.rb'
     - 'spec/models/repository_spec.rb'
     - 'spec/models/zoom_meeting_spec.rb'

.rubocop_todo/rspec/overwriting_setup.yml

@@ -12,4 +12,3 @@ RSpec/OverwritingSetup:
     - 'spec/models/todo_spec.rb'
     - 'spec/models/user_spec.rb'
     - 'spec/policies/ci/build_policy_spec.rb'
-    - 'spec/services/projects/container_repository/gitlab/cleanup_tags_service_spec.rb'

.rubocop_todo/rspec/verified_doubles.yml

@@ -96,6 +96,7 @@ RSpec/VerifiedDoubles:
     - 'ee/spec/serializers/ee/issue_entity_spec.rb'
     - 'ee/spec/serializers/ee/issue_sidebar_extras_entity_spec.rb'
     - 'ee/spec/serializers/ee/merge_request_poll_cached_widget_entity_spec.rb'
+    - 'ee/spec/serializers/ee/merge_request_poll_widget_entity_spec.rb'
     - 'ee/spec/serializers/ee/note_entity_spec.rb'
     - 'ee/spec/serializers/environment_entity_spec.rb'
     - 'ee/spec/serializers/epic_entity_spec.rb'
@@ -104,7 +105,6 @@ RSpec/VerifiedDoubles:
     - 'ee/spec/serializers/integrations/jira_serializers/issue_entity_spec.rb'
     - 'ee/spec/serializers/issues/linked_issue_feature_flag_entity_spec.rb'
     - 'ee/spec/serializers/linked_feature_flag_issue_entity_spec.rb'
-    - 'ee/spec/serializers/merge_request_poll_widget_entity_spec.rb'
     - 'ee/spec/serializers/merge_request_widget_entity_spec.rb'
     - 'ee/spec/serializers/test_reports_comparer_serializer_spec.rb'
     - 'ee/spec/serializers/user_analytics_entity_spec.rb'
@@ -259,7 +259,6 @@ RSpec/VerifiedDoubles:
     - 'spec/helpers/form_helper_spec.rb'
     - 'spec/helpers/gitlab_routing_helper_spec.rb'
     - 'spec/helpers/integrations_helper_spec.rb'
-    - 'spec/helpers/issuables_helper_spec.rb'
     - 'spec/helpers/markup_helper_spec.rb'
     - 'spec/helpers/merge_requests_helper_spec.rb'
     - 'spec/helpers/numbers_helper_spec.rb'
@@ -667,8 +666,6 @@ RSpec/VerifiedDoubles:
     - 'spec/models/external_issue_spec.rb'
     - 'spec/models/integrations/chat_message/pipeline_message_spec.rb'
     - 'spec/models/integrations/jira_spec.rb'
-    - 'spec/models/integrations/microsoft_teams_spec.rb'
-    - 'spec/models/integrations/pipelines_email_spec.rb'
     - 'spec/models/issue_spec.rb'
     - 'spec/models/key_spec.rb'
     - 'spec/models/merge_request_diff_commit_spec.rb'