Skip to content
GitLab
Next
Menu
Why GitLab
Pricing
Contact Sales
Explore
Why GitLab
Pricing
Contact Sales
Explore
Sign in
Get free trial
Primary navigation
Search or go to…
Project
GitLab FOSS
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Privacy statement
Keyboard shortcuts
?
What's new
4
Snippets
Groups
Projects
Show more breadcrumbs
GitLab.org
GitLab FOSS
Commits
547063b3
Commit
547063b3
authored
8 years ago
by
Douwe Maan
Browse files
Options
Downloads
Patches
Plain Diff
Update .rubocop_todo.yml
parent
fae2650c
No related branches found
No related tags found
1 merge request
!9432
Enable (and disable) more rubocops
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
.rubocop_todo.yml
+445
-128
445 additions, 128 deletions
.rubocop_todo.yml
with
445 additions
and
128 deletions
.rubocop_todo.yml
+
445
−
128
View file @
547063b3
# This configuration was generated by
# `rubocop --auto-gen-config
--exclude-limit 0
`
# on 2017-0
1-11 09:38:25 +00
00 using RuboCop version 0.46.0.
# `rubocop --auto-gen-config`
# on 2017-0
2-21 18:00:50 -06
00 using RuboCop version 0.46.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.
# Offense count: 2
7
# Offense count: 2
8
# Configuration parameters: Include.
# Include: **/Gemfile, **/gems.rb
Bundler/OrderedGems
:
Enabled
:
false
Exclude
:
-
'
Gemfile'
# Offense count: 17
5
# Offense count: 17
6
Lint/AmbiguousRegexpLiteral
:
Enabled
:
false
# Offense count: 5
3
# Offense count: 5
4
# Configuration parameters: AllowSafeAssignment.
Lint/AssignmentInCondition
:
Enabled
:
false
# Offense count: 2
0
# Offense count: 2
3
Lint/HandleExceptions
:
Enabled
:
false
# Offense count: 1
Lint/Loop
:
Enabled
:
false
Exclude
:
-
'
app/mailers/notify.rb'
# Offense count: 2
7
# Offense count:
3
2
Lint/ShadowingOuterLocalVariable
:
Enabled
:
false
# Offense count: 10
# Cop supports --auto-correct.
Lint/UnifiedInteger
:
Enabled
:
false
Exclude
:
-
'
spec/lib/gitlab/metrics/method_call_spec.rb'
-
'
spec/lib/gitlab/metrics/metric_spec.rb'
-
'
spec/lib/gitlab/metrics/system_spec.rb'
-
'
spec/lib/gitlab/metrics/transaction_spec.rb'
-
'
spec/models/repository_spec.rb'
# Offense count: 2
1
# Offense count: 2
3
# Cop supports --auto-correct.
Lint/UnneededSplatExpansion
:
Enabled
:
false
# Offense count: 82
Exclude
:
-
'
app/services/projects/update_pages_service.rb'
-
'
config/application.rb'
-
'
lib/banzai/filter/gollum_tags_filter.rb'
-
'
lib/bitbucket/page.rb'
-
'
lib/gitlab/markup_helper.rb'
-
'
spec/helpers/auth_helper_spec.rb'
-
'
spec/models/project_wiki_spec.rb'
-
'
spec/requests/api/projects_spec.rb'
-
'
spec/requests/api/tags_spec.rb'
-
'
spec/requests/api/v3/projects_spec.rb'
-
'
spec/support/seed_helper.rb'
-
'
spec/support/test_env.rb'
# Offense count: 89
# Cop supports --auto-correct.
# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
Lint/UnusedBlockArgument
:
Enabled
:
false
# Offense count: 17
3
# Offense count: 17
1
# Cop supports --auto-correct.
# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
Lint/UnusedMethodArgument
:
Enabled
:
false
# Offense count:
93
# Offense count:
114
# Configuration parameters: CountComments.
Metrics/BlockLength
:
Enabled
:
false
Max
:
302
# Offense count: 3
# Cop supports --auto-correct.
Performance/RedundantBlockCall
:
Enabled
:
false
Exclude
:
-
'
app/controllers/application_controller.rb'
-
'
lib/gitlab/optimistic_locking.rb'
-
'
lib/gitlab/shell.rb'
# Offense count: 5
# Cop supports --auto-correct.
Performance/RedundantMatch
:
Enabled
:
false
Exclude
:
-
'
app/models/external_issue.rb'
-
'
lib/ci/api/helpers.rb'
-
'
lib/extracts_path.rb'
-
'
lib/gitlab/diff/highlight.rb'
-
'
lib/gitlab/diff/parser.rb'
# Offense count:
3
2
# Offense count: 2
5
# Cop supports --auto-correct.
# Configuration parameters: MaxKeyValuePairs.
Performance/RedundantMerge
:
...
...
@@ -79,9 +106,15 @@ Performance/RedundantMerge:
# Offense count: 15
# Configuration parameters: CustomIncludeMethods.
RSpec/EmptyExampleGroup
:
Enabled
:
false
# Offense count: 58
Exclude
:
-
'
spec/features/issues_spec.rb'
-
'
spec/features/notes_on_merge_requests_spec.rb'
-
'
spec/lib/gitlab/git_access_spec.rb'
-
'
spec/models/project_snippet_spec.rb'
-
'
spec/models/protected_branch_spec.rb'
-
'
spec/routing/routing_spec.rb'
# Offense count: 63
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: implicit, each, example
RSpec/HookArgument
:
...
...
@@ -91,147 +124,223 @@ RSpec/HookArgument:
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: is_expected, should
RSpec/ImplicitExpect
:
Enabled
:
false
Exclude
:
-
'
spec/lib/banzai/renderer_spec.rb'
-
'
spec/models/project_group_link_spec.rb'
-
'
spec/models/project_services/external_wiki_service_spec.rb'
-
'
spec/models/project_spec.rb'
# Offense count: 2
37
# Offense count: 2
58
RSpec/LeadingSubject
:
Enabled
:
false
# Offense count: 2
53
# Offense count: 2
81
RSpec/LetSetup
:
Enabled
:
false
# Offense count: 13
RSpec/MessageChain
:
Enabled
:
false
# Offense count: 479
Exclude
:
-
'
spec/finders/move_to_project_finder_spec.rb'
-
'
spec/helpers/issues_helper_spec.rb'
-
'
spec/initializers/secret_token_spec.rb'
-
'
spec/models/ci/build_spec.rb'
-
'
spec/requests/api/internal_spec.rb'
-
'
spec/services/ci/retry_build_service_spec.rb'
-
'
spec/services/ci/retry_pipeline_service_spec.rb'
-
'
spec/services/merge_requests/build_service_spec.rb'
-
'
spec/workers/emails_on_push_worker_spec.rb'
# Offense count: 505
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: have_received, receive
RSpec/MessageSpies
:
Enabled
:
false
# Offense count: 3
036
# Offense count: 3
625
RSpec/MultipleExpectations
:
Enabled
:
false
Max
:
37
# Offense count: 2
133
# Offense count: 2
217
RSpec/NamedSubject
:
Enabled
:
false
# Offense count:
1974
# Offense count:
2126
# Configuration parameters: MaxNesting.
RSpec/NestedGroups
:
Enabled
:
false
# Offense count: 3
2
# Offense count: 3
6
RSpec/RepeatedDescription
:
Enabled
:
false
Exclude
:
-
'
spec/controllers/projects/todo_controller_spec.rb'
-
'
spec/features/boards/boards_spec.rb'
-
'
spec/helpers/issuables_helper_spec.rb'
-
'
spec/lib/banzai/filter/emoji_filter_spec.rb'
-
'
spec/models/commit_range_spec.rb'
-
'
spec/models/global_milestone_spec.rb'
-
'
spec/models/hooks/system_hook_spec.rb'
-
'
spec/requests/api/commits_spec.rb'
-
'
spec/requests/api/merge_requests_spec.rb'
-
'
spec/requests/api/milestones_spec.rb'
-
'
spec/requests/api/users_spec.rb'
-
'
spec/requests/api/v3/merge_requests_spec.rb'
-
'
spec/requests/lfs_http_spec.rb'
-
'
spec/routing/admin_routing_spec.rb'
-
'
spec/services/notification_service_spec.rb'
# Offense count: 1
RSpec/SingleArgumentMessageChain
:
Enabled
:
false
Exclude
:
-
'
spec/requests/api/internal_spec.rb'
# Offense count: 1
33
# Offense count: 1
40
RSpec/SubjectStub
:
Enabled
:
false
# Offense count: 1
04
# Offense count: 1
26
# Cop supports --auto-correct.
# Configuration parameters: Whitelist.
# Whitelist: find_by_sql
Rails/DynamicFindBy
:
Enabled
:
false
# Offense count:
93
2
# Offense count:
116
2
# Cop supports --auto-correct.
# Configuration parameters: Include.
# Include: spec/**/*, test/**/*
Rails/HttpPositionalArguments
:
Enabled
:
false
# Offense count: 5
5
# Offense count: 5
6
Rails/OutputSafety
:
Enabled
:
false
# Offense count:
18
2
# Offense count:
20
2
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: strict, flexible
Rails/TimeZone
:
Enabled
:
false
# Offense count: 1
5
# Offense count: 1
6
# Cop supports --auto-correct.
# Configuration parameters: Include.
# Include: app/models/**/*.rb
Rails/Validation
:
Enabled
:
false
Exclude
:
-
'
app/models/ci/build.rb'
-
'
app/models/ci/pipeline.rb'
-
'
app/models/ci/runner_project.rb'
-
'
app/models/ci/trigger.rb'
-
'
app/models/commit_status.rb'
-
'
app/models/members/group_member.rb'
-
'
app/models/members/project_member.rb'
-
'
app/models/pages_domain.rb'
-
'
app/models/project.rb'
-
'
app/models/protected_branch.rb'
-
'
app/models/user.rb'
# Offense count: 8
# Cop supports --auto-correct.
# Configuration parameters: AutoCorrect.
Security/JSONLoad
:
Enabled
:
false
Exclude
:
-
'
db/migrate/20161019190736_migrate_sidekiq_queues_from_default.rb'
-
'
db/migrate/20161024042317_migrate_mailroom_queue_from_default.rb'
-
'
db/migrate/20161124141322_migrate_process_commit_worker_jobs.rb'
-
'
spec/migrations/migrate_process_commit_worker_jobs_spec.rb'
-
'
spec/models/project_services/irker_service_spec.rb'
-
'
spec/support/stub_gitlab_calls.rb'
# Offense count:
346
# Offense count:
431
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: with_first_parameter, with_fixed_indentation
Style/AlignParameters
:
Enabled
:
false
# Offense count: 5
4
# Offense count: 5
5
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: percent_q, bare_percent
Style/BarePercentLiterals
:
Enabled
:
false
# Offense count: 3
58
# Offense count: 3
99
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: braces, no_braces, context_dependent
Style/BracesAroundHashParameters
:
Enabled
:
false
# Offense count:
6
# Offense count:
7
Style/CaseEquality
:
Enabled
:
false
Exclude
:
-
'
app/helpers/auth_helper.rb'
-
'
app/helpers/builds_helper.rb'
-
'
app/models/commit.rb'
-
'
app/models/protected_branch.rb'
-
'
app/services/projects/download_service.rb'
-
'
config/initializers/trusted_proxies.rb'
-
'
lib/gitlab/route_map.rb'
# Offense count: 3
7
# Offense count: 3
3
# Cop supports --auto-correct.
Style/ColonMethodCall
:
Enabled
:
false
# Offense count:
4
# Offense count:
2
# Cop supports --auto-correct.
# Configuration parameters: Keywords.
# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW
Style/CommentAnnotation
:
Enabled
:
false
Exclude
:
-
'
config/routes/user.rb'
-
'
spec/requests/api/v3/project_snippets_spec.rb'
# Offense count: 2
9
# Offense count:
3
2
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly.
# SupportedStyles: assign_to_condition, assign_inside_condition
Style/ConditionalAssignment
:
Enabled
:
false
# Offense count: 1
210
# Offense count: 1
304
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: leading, trailing
Style/DotPosition
:
Enabled
:
false
# Offense count: 1
8
# Offense count:
2
1
Style/DoubleNegation
:
Enabled
:
false
Exclude
:
-
'
app/controllers/users_controller.rb'
-
'
app/models/commit.rb'
-
'
app/models/merge_request.rb'
-
'
app/models/project.rb'
-
'
app/models/project_services/buildkite_service.rb'
-
'
app/models/project_services/drone_ci_service.rb'
-
'
app/models/project_wiki.rb'
-
'
app/models/user.rb'
-
'
config/initializers/6_validations.rb'
-
'
lib/banzai/filter/abstract_reference_filter.rb'
-
'
lib/banzai/filter/relative_link_filter.rb'
-
'
lib/gitlab/git/diff_collection.rb'
-
'
lib/gitlab/git/repository.rb'
-
'
lib/gitlab/sherlock.rb'
-
'
lib/gitlab/sherlock/middleware.rb'
# Offense count:
7
# Offense count:
6
# Cop supports --auto-correct.
Style/EachWithObject
:
Enabled
:
false
Exclude
:
-
'
app/services/merge_requests/get_urls_service.rb'
-
'
lib/ci/ansi2html.rb'
-
'
lib/expand_variables.rb'
-
'
lib/gitlab/ee_compat_check.rb'
-
'
lib/gitlab/import_export/members_mapper.rb'
-
'
lib/gitlab/import_export/relation_factory.rb'
# Offense count: 24
# Cop supports --auto-correct.
...
...
@@ -243,16 +352,20 @@ Style/EmptyElse:
# Offense count: 4
# Cop supports --auto-correct.
Style/EmptyLiteral
:
Enabled
:
false
Exclude
:
-
'
features/steps/project/commits/commits.rb'
-
'
lib/gitlab/fogbugz_import/importer.rb'
-
'
lib/gitlab/git/diff_collection.rb'
-
'
spec/lib/gitlab/workhorse_spec.rb'
# Offense count: 5
7
# Offense count: 5
5
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: compact, expanded
Style/EmptyMethod
:
Enabled
:
false
# Offense count: 1
4
7
# Offense count: 17
3
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
Style/ExtraSpacing
:
...
...
@@ -262,64 +375,110 @@ Style/ExtraSpacing:
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: format, sprintf, percent
Style/FormatString
:
Enabled
:
false
# Offense count: 238
Exclude
:
-
'
app/models/ci/pipeline.rb'
-
'
app/services/gravatar_service.rb'
-
'
config/initializers/rack_lineprof.rb'
-
'
lib/gitlab/version_info.rb'
-
'
spec/factories/lfs_objects.rb'
-
'
spec/services/issues/move_service_spec.rb'
# Offense count: 261
# Configuration parameters: MinBodyLength.
Style/GuardClause
:
Enabled
:
false
# Offense count: 1
1
# Offense count: 1
2
Style/IfInsideElse
:
Enabled
:
false
# Offense count: 173
Exclude
:
-
'
app/controllers/projects/forks_controller.rb'
-
'
app/controllers/projects/imports_controller.rb'
-
'
app/helpers/milestones_helper.rb'
-
'
app/helpers/projects_helper.rb'
-
'
app/services/system_note_service.rb'
-
'
config/initializers/1_settings.rb'
-
'
lib/gitlab/auth.rb'
-
'
lib/gitlab/checks/change_access.rb'
-
'
lib/gitlab/database.rb'
-
'
spec/controllers/projects/merge_requests_controller_spec.rb'
-
'
spec/support/import_export/export_file_helper.rb'
# Offense count: 178
# Cop supports --auto-correct.
# Configuration parameters: MaxLineLength.
Style/IfUnlessModifier
:
Enabled
:
false
# Offense count:
55
# Offense count:
61
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: special_inside_parentheses, consistent, align_brackets
Style/IndentArray
:
Enabled
:
false
# Offense count: 1
0
1
# Offense count: 11
0
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: special_inside_parentheses, consistent, align_braces
Style/IndentHash
:
Enabled
:
false
# Offense count: 4
1
# Offense count: 4
5
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: line_count_dependent, lambda, literal
Style/Lambda
:
Enabled
:
false
# Offense count:
5
# Offense count:
7
# Cop supports --auto-correct.
Style/LineEndConcatenation
:
Enabled
:
false
Exclude
:
-
'
app/helpers/tree_helper.rb'
-
'
app/models/merge_request.rb'
-
'
app/services/git_operation_service.rb'
-
'
spec/lib/gitlab/gfm/reference_rewriter_spec.rb'
-
'
spec/lib/gitlab/incoming_email_spec.rb'
# Offense count:
19
# Offense count:
22
# Cop supports --auto-correct.
Style/MethodCallParentheses
:
Enabled
:
false
Exclude
:
-
'
lib/ci/ansi2html.rb'
-
'
spec/controllers/projects/issues_controller_spec.rb'
-
'
spec/controllers/projects/merge_requests_controller_spec.rb'
-
'
spec/controllers/projects/snippets_controller_spec.rb'
-
'
spec/features/dashboard/datetime_on_tooltips_spec.rb'
-
'
spec/features/issues/filtered_search/dropdown_assignee_spec.rb'
-
'
spec/features/issues/filtered_search/dropdown_author_spec.rb'
-
'
spec/features/issues/filtered_search/dropdown_milestone_spec.rb'
-
'
spec/features/issues/filtered_search/filter_issues_spec.rb'
-
'
spec/helpers/submodule_helper_spec.rb'
-
'
spec/lib/gitlab/git/repository_spec.rb'
-
'
spec/requests/api/internal_spec.rb'
# Offense count: 9
Style/MethodMissing
:
Enabled
:
false
Exclude
:
-
'
app/controllers/projects/application_controller.rb'
-
'
app/models/commit.rb'
-
'
app/models/network/commit.rb'
-
'
app/models/repository.rb'
-
'
config/initializers/gollum.rb'
-
'
lib/bitbucket/collection.rb'
-
'
lib/gitlab/github_import/client.rb'
-
'
lib/gitlab/lazy.rb'
-
'
lib/uploaded_file.rb'
# Offense count: 3
# Cop supports --auto-correct.
Style/MultilineIfModifier
:
Enabled
:
false
Exclude
:
-
'
app/helpers/snippets_helper.rb'
-
'
app/models/project_wiki.rb'
-
'
lib/gitlab/workhorse.rb'
# Offense count: 17
9
# Offense count: 1
8
7
# Cop supports --auto-correct.
Style/MutableConstant
:
Enabled
:
false
...
...
@@ -327,35 +486,64 @@ Style/MutableConstant:
# Offense count: 8
# Cop supports --auto-correct.
Style/NestedParenthesizedCalls
:
Enabled
:
false
Exclude
:
-
'
app/helpers/commits_helper.rb'
-
'
app/workers/irker_worker.rb'
-
'
spec/lib/gitlab/ci/build/artifacts/metadata/entry_spec.rb'
-
'
spec/lib/gitlab/email/message/repository_push_spec.rb'
# Offense count: 1
3
# Offense count: 1
5
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
# SupportedStyles: skip_modifier_ifs, always
Style/Next
:
Enabled
:
false
Exclude
:
-
'
app/models/namespace.rb'
-
'
app/models/user.rb'
-
'
app/services/merge_requests/refresh_service.rb'
-
'
config/initializers/secret_token.rb'
-
'
db/migrate/20161220141214_remove_dot_git_from_group_names.rb'
-
'
db/migrate/20161226122833_remove_dot_git_from_usernames.rb'
-
'
lib/banzai/filter/math_filter.rb'
-
'
lib/banzai/filter/table_of_contents_filter.rb'
-
'
lib/gitlab/fogbugz_import/importer.rb'
-
'
lib/gitlab/metrics/instrumentation.rb'
-
'
lib/gitlab/metrics/sampler.rb'
-
'
lib/gitlab/project_search_results.rb'
# Offense count: 19
# Cop supports --auto-correct.
# Configuration parameters: EnforcedOctalStyle, SupportedOctalStyles.
# SupportedOctalStyles: zero_with_o, zero_only
Style/NumericLiteralPrefix
:
Enabled
:
false
# Offense count: 19
Exclude
:
-
'
config/initializers/1_settings.rb'
-
'
config/initializers/secret_token.rb'
-
'
lib/gitlab/import_export/command_line_util.rb'
-
'
lib/gitlab/shell.rb'
-
'
lib/gitlab/workhorse.rb'
-
'
spec/features/projects/import_export/export_file_spec.rb'
-
'
spec/lib/gitlab/git/blob_spec.rb'
-
'
spec/lib/gitlab/git/hook_spec.rb'
-
'
spec/lib/gitlab/git/repository_spec.rb'
-
'
spec/lib/gitlab/workhorse_spec.rb'
-
'
spec/support/import_export/export_file_helper.rb'
-
'
spec/support/test_env.rb'
-
'
spec/tasks/gitlab/backup_rake_spec.rb'
# Offense count: 68
# Cop supports --auto-correct.
# Configuration parameters: AutoCorrect, EnforcedStyle, SupportedStyles.
# SupportedStyles: predicate, comparison
Style/NumericPredicate
:
Enabled
:
false
# Offense count: 3
4
# Offense count: 3
6
# Cop supports --auto-correct.
Style/ParallelAssignment
:
Enabled
:
false
# Offense count: 4
17
# Offense count: 4
59
# Cop supports --auto-correct.
# Configuration parameters: PreferredDelimiters.
Style/PercentLiteralDelimiters
:
...
...
@@ -366,14 +554,30 @@ Style/PercentLiteralDelimiters:
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: lower_case_q, upper_case_q
Style/PercentQLiterals
:
Enabled
:
false
Exclude
:
-
'
spec/lib/gitlab/diff/highlight_spec.rb'
-
'
spec/models/project_services/bamboo_service_spec.rb'
-
'
spec/models/project_services/buildkite_service_spec.rb'
-
'
spec/models/project_services/drone_ci_service_spec.rb'
-
'
spec/models/project_services/teamcity_service_spec.rb'
-
'
spec/workers/repository_import_worker_spec.rb'
# Offense count: 13
# Cop supports --auto-correct.
Style/PerlBackrefs
:
Enabled
:
false
# Offense count: 64
Exclude
:
-
'
app/controllers/projects/application_controller.rb'
-
'
app/helpers/submodule_helper.rb'
-
'
lib/banzai/filter/abstract_reference_filter.rb'
-
'
lib/banzai/filter/autolink_filter.rb'
-
'
lib/banzai/filter/emoji_filter.rb'
-
'
lib/banzai/filter/gollum_tags_filter.rb'
-
'
lib/expand_variables.rb'
-
'
lib/gitlab/diff/highlight.rb'
-
'
lib/gitlab/search_results.rb'
-
'
lib/gitlab/sherlock/query.rb'
# Offense count: 72
# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
# NamePrefix: is_, has_, have_
# NamePrefixBlacklist: is_, has_, have_
...
...
@@ -381,7 +585,7 @@ Style/PerlBackrefs:
Style/PredicateName
:
Enabled
:
false
# Offense count: 3
3
# Offense count: 3
9
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: short, verbose
...
...
@@ -391,44 +595,76 @@ Style/PreferredHashMethods:
# Offense count: 8
# Cop supports --auto-correct.
Style/Proc
:
Enabled
:
false
Exclude
:
-
'
app/mailers/base_mailer.rb'
-
'
app/models/milestone.rb'
-
'
app/models/service.rb'
-
'
lib/api/api_guard.rb'
-
'
lib/gitlab/ldap/config.rb'
-
'
spec/initializers/trusted_proxies_spec.rb'
# Offense count:
50
# Offense count:
62
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: compact, exploded
Style/RaiseArgs
:
Enabled
:
false
# Offense count:
4
# Offense count:
3
# Cop supports --auto-correct.
Style/RedundantBegin
:
Enabled
:
false
Exclude
:
-
'
app/models/merge_request.rb'
-
'
app/services/projects/import_service.rb'
-
'
lib/gitlab/git/commit.rb'
# Offense count: 2
9
# Offense count:
3
2
# Cop supports --auto-correct.
Style/RedundantFreeze
:
Enabled
:
false
Exclude
:
-
'
app/models/commit.rb'
-
'
app/models/merge_request.rb'
-
'
app/validators/color_validator.rb'
-
'
app/validators/line_code_validator.rb'
-
'
lib/api/templates.rb'
-
'
lib/api/v3/templates.rb'
-
'
lib/banzai/filter/blockquote_fence_filter.rb'
-
'
lib/banzai/filter/gollum_tags_filter.rb'
-
'
lib/banzai/filter/yaml_front_matter_filter.rb'
-
'
lib/gitlab/diff/inline_diff.rb'
-
'
lib/gitlab/ee_compat_check.rb'
-
'
lib/gitlab/import_export/relation_factory.rb'
-
'
lib/gitlab/middleware/static.rb'
-
'
lib/gitlab/regex.rb'
# Offense count: 1
1
# Offense count: 1
5
# Cop supports --auto-correct.
# Configuration parameters: AllowMultipleReturnValues.
Style/RedundantReturn
:
Enabled
:
false
# Offense count: 359
Exclude
:
-
'
app/controllers/application_controller.rb'
-
'
app/controllers/concerns/issuable_actions.rb'
-
'
app/controllers/groups/application_controller.rb'
-
'
app/controllers/groups_controller.rb'
-
'
app/controllers/omniauth_callbacks_controller.rb'
-
'
app/controllers/profiles/keys_controller.rb'
-
'
app/controllers/projects/labels_controller.rb'
-
'
app/controllers/projects/milestones_controller.rb'
-
'
app/services/access_token_validation_service.rb'
# Offense count: 365
# Cop supports --auto-correct.
Style/RedundantSelf
:
Enabled
:
false
# Offense count: 10
5
# Offense count: 10
7
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
# SupportedStyles: slashes, percent_r, mixed
Style/RegexpLiteral
:
Enabled
:
false
# Offense count:
19
# Offense count:
22
# Cop supports --auto-correct.
Style/RescueModifier
:
Enabled
:
false
...
...
@@ -436,21 +672,29 @@ Style/RescueModifier:
# Offense count: 7
# Cop supports --auto-correct.
Style/SelfAssignment
:
Enabled
:
false
Exclude
:
-
'
app/models/project_team.rb'
-
'
app/services/notification_service.rb'
-
'
lib/api/runners.rb'
-
'
spec/features/merge_requests/diff_notes_resolve_spec.rb'
-
'
spec/support/import_export/configuration_helper.rb'
# Offense count: 2
# Configuration parameters: Methods.
# Methods: {"reduce"=>["acc", "elem"]}, {"inject"=>["acc", "elem"]}
Style/SingleLineBlockParams
:
Enabled
:
false
Exclude
:
-
'
app/models/commit.rb'
-
'
spec/support/services_shared_context.rb'
# Offense count: 50
# Cop supports --auto-correct.
# Configuration parameters: AllowIfMethodIsEmpty.
Style/SingleLineMethods
:
Enabled
:
false
Exclude
:
-
'
lib/ci/ansi2html.rb'
# Offense count: 1
38
# Offense count: 1
50
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: space, no_space
...
...
@@ -461,28 +705,48 @@ Style/SpaceBeforeBlockBraces:
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment.
Style/SpaceBeforeFirstArg
:
Enabled
:
false
Exclude
:
-
'
config/routes/project.rb'
-
'
features/steps/project/source/browse_files.rb'
-
'
features/steps/project/source/markdown_render.rb'
-
'
spec/routing/project_routing_spec.rb'
-
'
spec/services/system_note_service_spec.rb'
# Offense count: 3
7
# Offense count: 3
8
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: require_no_space, require_space
Style/SpaceInLambdaLiteral
:
Enabled
:
false
# Offense count: 174
Exclude
:
-
'
app/models/commit_status.rb'
-
'
app/models/concerns/mentionable.rb'
-
'
app/models/issue.rb'
-
'
app/models/member.rb'
-
'
lib/api/entities.rb'
-
'
lib/file_size_validator.rb'
-
'
lib/gitlab/visibility_level.rb'
-
'
spec/models/concerns/participable_spec.rb'
-
'
spec/models/cycle_analytics/code_spec.rb'
-
'
spec/models/cycle_analytics/issue_spec.rb'
-
'
spec/models/cycle_analytics/plan_spec.rb'
-
'
spec/models/cycle_analytics/production_spec.rb'
-
'
spec/models/cycle_analytics/review_spec.rb'
-
'
spec/models/cycle_analytics/staging_spec.rb'
-
'
spec/models/cycle_analytics/test_spec.rb'
# Offense count: 205
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
# SupportedStyles: space, no_space
Style/SpaceInsideBlockBraces
:
Enabled
:
false
# Offense count: 1
15
# Offense count: 1
20
# Cop supports --auto-correct.
Style/SpaceInsideBrackets
:
Enabled
:
false
# Offense count:
77
# Offense count:
90
# Cop supports --auto-correct.
Style/SpaceInsideParens
:
Enabled
:
false
...
...
@@ -490,9 +754,10 @@ Style/SpaceInsideParens:
# Offense count: 4
# Cop supports --auto-correct.
Style/SpaceInsidePercentLiteralDelimiters
:
Enabled
:
false
Exclude
:
-
'
lib/gitlab/git_access.rb'
# Offense count: 5
3
# Offense count: 5
2
# Cop supports --auto-correct.
# Configuration parameters: SupportedStyles.
# SupportedStyles: use_perl_names, use_english_names
...
...
@@ -504,9 +769,23 @@ Style/SpecialGlobalVars:
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: single_quotes, double_quotes
Style/StringLiteralsInInterpolation
:
Enabled
:
false
Exclude
:
-
'
app/helpers/labels_helper.rb'
-
'
app/helpers/time_helper.rb'
-
'
app/helpers/todos_helper.rb'
-
'
app/models/application_setting.rb'
-
'
app/models/project_services/campfire_service.rb'
-
'
app/models/project_services/jira_service.rb'
-
'
db/migrate/20161017125927_add_unique_index_to_labels.rb'
-
'
features/steps/groups.rb'
-
'
features/steps/project/merge_requests.rb'
-
'
lib/banzai/filter/abstract_reference_filter.rb'
-
'
lib/ci/gitlab_ci_yaml_processor.rb'
-
'
lib/gitlab/google_code_import/importer.rb'
-
'
spec/lib/banzai/filter/issue_reference_filter_spec.rb'
-
'
spec/models/project_services/hipchat_service_spec.rb'
# Offense count: 5
4
# Offense count: 5
7
# Cop supports --auto-correct.
# Configuration parameters: IgnoredMethods.
# IgnoredMethods: respond_to, define_method
...
...
@@ -518,16 +797,21 @@ Style/SymbolProc:
# Configuration parameters: EnforcedStyle, SupportedStyles, AllowSafeAssignment.
# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex
Style/TernaryParentheses
:
Enabled
:
false
Exclude
:
-
'
features/support/capybara.rb'
-
'
lib/api/v3/projects.rb'
-
'
lib/banzai/filter/table_of_contents_filter.rb'
-
'
lib/gitlab/ci/build/artifacts/metadata/entry.rb'
-
'
spec/support/capybara.rb'
# Offense count: 3
6
# Offense count:
4
3
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
# SupportedStyles: comma, consistent_comma, no_comma
Style/TrailingCommaInArguments
:
Enabled
:
false
# Offense count: 15
0
# Offense count: 15
8
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
# SupportedStyles: comma, consistent_comma, no_comma
...
...
@@ -538,9 +822,15 @@ Style/TrailingCommaInLiteral:
# Cop supports --auto-correct.
# Configuration parameters: AllowNamedUnderscoreVariables.
Style/TrailingUnderscoreVariable
:
Enabled
:
false
Exclude
:
-
'
app/controllers/admin/background_jobs_controller.rb'
-
'
app/controllers/invites_controller.rb'
-
'
app/controllers/projects/git_http_client_controller.rb'
-
'
app/helpers/tab_helper.rb'
-
'
lib/gitlab/git/repository.rb'
-
'
lib/gitlab/logger.rb'
# Offense count:
6
7
# Offense count: 7
6
# Cop supports --auto-correct.
Style/TrailingWhitespace
:
Enabled
:
false
...
...
@@ -550,19 +840,46 @@ Style/TrailingWhitespace:
# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
Style/TrivialAccessors
:
Enabled
:
false
Exclude
:
-
'
app/models/external_issue.rb'
-
'
app/serializers/base_serializer.rb'
-
'
lib/gitlab/ldap/person.rb'
# Offense count: 2
# Cop supports --auto-correct.
Style/UnlessElse
:
Enabled
:
false
Exclude
:
-
'
lib/gitlab/project_search_results.rb'
-
'
spec/features/issues/award_emoji_spec.rb'
# Offense count: 1
7
# Offense count: 1
9
# Cop supports --auto-correct.
Style/UnneededInterpolation
:
Enabled
:
false
Exclude
:
-
'
app/helpers/boards_helper.rb'
-
'
app/helpers/projects_helper.rb'
-
'
app/helpers/search_helper.rb'
-
'
app/helpers/time_helper.rb'
-
'
app/models/merge_request.rb'
-
'
app/models/project_services/pushover_service.rb'
-
'
features/steps/project/forked_merge_requests.rb'
-
'
spec/controllers/admin/services_controller_spec.rb'
-
'
spec/features/admin/admin_projects_spec.rb'
-
'
spec/features/issues_spec.rb'
-
'
spec/features/projects/branches_spec.rb'
-
'
spec/features/projects/issuable_templates_spec.rb'
-
'
spec/lib/banzai/filter/issue_reference_filter_spec.rb'
-
'
spec/requests/api/issues_spec.rb'
-
'
spec/views/projects/commit/_commit_box.html.haml_spec.rb'
# Offense count: 8
# Cop supports --auto-correct.
Style/ZeroLengthPredicate
:
Enabled
:
false
Exclude
:
-
'
app/models/deploy_key.rb'
-
'
app/models/merge_request.rb'
-
'
app/models/network/commit.rb'
-
'
app/models/network/graph.rb'
-
'
app/models/project_services/asana_service.rb'
-
'
app/models/repository.rb'
-
'
lib/extracts_path.rb'
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment