Adds cop to enforce string limits on migrations

This cop will analyze migrations that add columns with string, and
report an offense if the string has no limit enforced

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/64505

db/migrate/20171230123729_init_schema.rb

@@ -5,6 +5,7 @@
 # rubocop:disable Metrics/AbcSize
 # rubocop:disable Migration/AddConcurrentForeignKey
 # rubocop:disable Style/WordArray
+# rubocop:disable Migration/AddLimitToStringColumns
 
 class InitSchema < ActiveRecord::Migration[4.2]
   DOWNTIME = false
@@ -1852,3 +1853,4 @@ def down
     raise ActiveRecord::IrreversibleMigration, "The initial migration is not revertable"
   end
 end
+# rubocop:enable Migration/AddLimitToStringColumns

db/migrate/20180101160629_create_prometheus_metrics.rb

@@ -4,6 +4,7 @@ class CreatePrometheusMetrics < ActiveRecord::Migration[4.2]
   DOWNTIME = false
 
   def change
+    # rubocop:disable Migration/AddLimitToStringColumns
     create_table :prometheus_metrics do |t|
       t.references :project, index: true, foreign_key: { on_delete: :cascade }, null: false
       t.string :title, null: false
@@ -14,5 +15,6 @@ def change
       t.integer :group, null: false, index: true
       t.timestamps_with_timezone null: false
     end
+    # rubocop:enable Migration/AddLimitToStringColumns
   end
 end

db/migrate/20180122162010_add_auto_devops_domain_to_application_settings.rb

@@ -8,6 +8,6 @@ class AddAutoDevopsDomainToApplicationSettings < ActiveRecord::Migration[4.2]
   DOWNTIME = false
 
   def change
-    add_column :application_settings, :auto_devops_domain, :string
+    add_column :application_settings, :auto_devops_domain, :string # rubocop:disable Migration/AddLimitToStringColumns
   end
 end

db/migrate/20180129193323_add_uploads_builder_context.rb

@@ -8,7 +8,9 @@ class AddUploadsBuilderContext < ActiveRecord::Migration[4.2]
   DOWNTIME = false
 
   def change
+    # rubocop:disable Migration/AddLimitToStringColumns
     add_column :uploads, :mount_point, :string
     add_column :uploads, :secret, :string
+    # rubocop:enable Migration/AddLimitToStringColumns
   end
 end

db/migrate/20180212030105_add_external_ip_to_clusters_applications_ingress.rb

@@ -4,6 +4,6 @@ class AddExternalIpToClustersApplicationsIngress < ActiveRecord::Migration[4.2]
   DOWNTIME = false
 
   def change
-    add_column :clusters_applications_ingress, :external_ip, :string
+    add_column :clusters_applications_ingress, :external_ip, :string # rubocop:disable Migration/AddLimitToStringColumns
   end
 end

db/migrate/20180214093516_create_badges.rb

@@ -2,6 +2,7 @@ class CreateBadges < ActiveRecord::Migration[4.2]
   DOWNTIME = false
 
   def change
+    # rubocop:disable Migration/AddLimitToStringColumns
     create_table :badges do |t|
       t.string     :link_url, null: false
       t.string     :image_url, null: false
@@ -11,6 +12,7 @@ def change
 
       t.timestamps_with_timezone null: false
     end
+    # rubocop:enable Migration/AddLimitToStringColumns
 
     # rubocop:disable Migration/AddConcurrentForeignKey
     add_foreign_key :badges, :namespaces, column: :group_id, on_delete: :cascade

db/migrate/20180214155405_create_clusters_applications_runners.rb

@@ -13,7 +13,7 @@ def up
       t.index :cluster_id, unique: true
       t.integer :status, null: false
       t.timestamps_with_timezone null: false
-      t.string :version, null: false
+      t.string :version, null: false # rubocop:disable Migration/AddLimitToStringColumns
       t.text :status_reason
     end
 

db/migrate/20180216120000_add_pages_domain_verification.rb

@@ -3,6 +3,6 @@ class AddPagesDomainVerification < ActiveRecord::Migration[4.2]
 
   def change
     add_column :pages_domains, :verified_at, :datetime_with_timezone
-    add_column :pages_domains, :verification_code, :string
+    add_column :pages_domains, :verification_code, :string # rubocop:disable Migration/AddLimitToStringColumns
   end
 end

db/migrate/20180222043024_add_ip_address_to_runner.rb

@@ -4,6 +4,6 @@ class AddIpAddressToRunner < ActiveRecord::Migration[4.2]
   DOWNTIME = false
 
   def change
-    add_column :ci_runners, :ip_address, :string
+    add_column :ci_runners, :ip_address, :string # rubocop:disable Migration/AddLimitToStringColumns
   end
 end

db/migrate/20180308125206_add_user_internal_regex_to_application_setting.rb

@@ -4,7 +4,7 @@ class AddUserInternalRegexToApplicationSetting < ActiveRecord::Migration[4.2]
   DOWNTIME = false
 
   def up
-    add_column :application_settings, :user_default_internal_regex, :string, null: true
+    add_column :application_settings, :user_default_internal_regex, :string, null: true # rubocop:disable Migration/AddLimitToStringColumns
   end
 
   def down

db/migrate/20180315160435_add_external_auth_mutual_tls_fields_to_project_settings.rb

@@ -2,6 +2,7 @@ class AddExternalAuthMutualTlsFieldsToProjectSettings < ActiveRecord::Migration[
   DOWNTIME = false
 
   def change
+    # rubocop:disable Migration/AddLimitToStringColumns
     add_column :application_settings,
                :external_auth_client_cert, :text
     add_column :application_settings,
@@ -12,5 +13,6 @@ def change
                :encrypted_external_auth_client_key_pass, :string
     add_column :application_settings,
                :encrypted_external_auth_client_key_pass_iv, :string
+    # rubocop:enable Migration/AddLimitToStringColumns
   end
 end

db/migrate/20180319190020_create_deploy_tokens.rb

@@ -2,6 +2,7 @@ class CreateDeployTokens < ActiveRecord::Migration[4.2]
   DOWNTIME = false
 
   def change
+    # rubocop:disable Migration/AddLimitToStringColumns
     create_table :deploy_tokens do |t|
       t.boolean :revoked, default: false
       t.boolean :read_repository, null: false, default: false
@@ -15,5 +16,6 @@ def change
 
       t.index [:token, :expires_at, :id], where: "(revoked IS FALSE)"
     end
+    # rubocop:enable Migration/AddLimitToStringColumns
   end
 end

db/migrate/20180502122856_create_project_mirror_data.rb

@@ -3,6 +3,7 @@ class CreateProjectMirrorData < ActiveRecord::Migration[4.2]
 
   DOWNTIME = false
 
+  # rubocop:disable Migration/AddLimitToStringColumns
   def up
     if table_exists?(:project_mirror_data)
       add_column :project_mirror_data, :status, :string unless column_exists?(:project_mirror_data, :status)
@@ -17,6 +18,7 @@ def up
       end
     end
   end
+  # rubocop:enable Migration/AddLimitToStringColumns
 
   def down
     remove_column :project_mirror_data, :status

db/migrate/20180503131624_create_remote_mirrors.rb

@@ -5,6 +5,7 @@ class CreateRemoteMirrors < ActiveRecord::Migration[4.2]
 
   disable_ddl_transaction!
 
+  # rubocop:disable Migration/AddLimitToStringColumns
   def up
     return if table_exists?(:remote_mirrors)
 
@@ -27,6 +28,7 @@ def up
       t.timestamps null: false
     end
   end
+  # rubocop:enable Migration/AddLimitToStringColumns
 
   def down
     # ee/db/migrate/20160321161032_create_remote_mirrors_ee.rb will remove the table

db/migrate/20180503175053_ensure_missing_columns_to_project_mirror_data.rb

@@ -4,8 +4,8 @@ class EnsureMissingColumnsToProjectMirrorData < ActiveRecord::Migration[4.2]
   DOWNTIME = false
 
   def up
-    add_column :project_mirror_data, :status, :string unless column_exists?(:project_mirror_data, :status)
-    add_column :project_mirror_data, :jid, :string unless column_exists?(:project_mirror_data, :jid)
+    add_column :project_mirror_data, :status, :string unless column_exists?(:project_mirror_data, :status) # rubocop:disable Migration/AddLimitToStringColumns
+    add_column :project_mirror_data, :jid, :string unless column_exists?(:project_mirror_data, :jid) # rubocop:disable Migration/AddLimitToStringColumns
     add_column :project_mirror_data, :last_error, :text unless column_exists?(:project_mirror_data, :last_error)
   end
 

db/migrate/20180511131058_create_clusters_applications_jupyter.rb

@@ -7,17 +7,19 @@ class CreateClustersApplicationsJupyter < ActiveRecord::Migration[4.2]
   DOWNTIME = false
 
   def change
+    # rubocop:disable Migration/AddLimitToStringColumns
     create_table :clusters_applications_jupyter do |t|
       t.references :cluster, null: false, unique: true, foreign_key: { on_delete: :cascade }
       t.references :oauth_application, foreign_key: { on_delete: :nullify }
 
       t.integer :status, null: false
-      t.string :version, null: false
-      t.string :hostname
+      t.string :version, null: false # rubocop:disable Migration/AddLimitToStringColumns
+      t.string :hostname # rubocop:disable Migration/AddLimitToStringColumns
 
       t.timestamps_with_timezone null: false
 
       t.text :status_reason
     end
+    # rubocop:enable Migration/AddLimitToStringColumns
   end
 end

db/migrate/20180515121227_create_notes_diff_files.rb

@@ -4,6 +4,7 @@ class CreateNotesDiffFiles < ActiveRecord::Migration[4.2]
   disable_ddl_transaction!
 
   def change
+    # rubocop:disable Migration/AddLimitToStringColumns
     create_table :note_diff_files do |t|
       t.references :diff_note, references: :notes, null: false, index: { unique: true }
       t.text :diff, null: false
@@ -18,5 +19,6 @@ def change
 
     # rubocop:disable Migration/AddConcurrentForeignKey
     add_foreign_key :note_diff_files, :notes, column: :diff_note_id, on_delete: :cascade
+    # rubocop:enable Migration/AddLimitToStringColumns
   end
 end

db/migrate/20180529093006_ensure_remote_mirror_columns.rb

@@ -8,7 +8,7 @@ class EnsureRemoteMirrorColumns < ActiveRecord::Migration[4.2]
   def up
     # rubocop:disable Migration/Datetime
     add_column :remote_mirrors, :last_update_started_at, :datetime unless column_exists?(:remote_mirrors, :last_update_started_at)
-    add_column :remote_mirrors, :remote_name, :string unless column_exists?(:remote_mirrors, :remote_name)
+    add_column :remote_mirrors, :remote_name, :string unless column_exists?(:remote_mirrors, :remote_name) # rubocop:disable Migration/AddLimitToStringColumns
 
     unless column_exists?(:remote_mirrors, :only_protected_branches)
       add_column_with_default(:remote_mirrors,

db/migrate/20180531185349_add_repository_languages.rb

@@ -4,6 +4,7 @@ class AddRepositoryLanguages < ActiveRecord::Migration[4.2]
   DOWNTIME = false
 
   def up
+    # rubocop:disable Migration/AddLimitToStringColumns
     create_table(:programming_languages) do |t|
       t.string :name, null: false
       t.string :color, null: false
@@ -19,6 +20,7 @@ def up
     add_index :programming_languages, :name, unique: true
     add_index :repository_languages, [:project_id, :programming_language_id],
       unique: true, name: "index_repository_languages_on_project_and_languages_id"
+    # rubocop:enable Migration/AddLimitToStringColumns
   end
 
   def down

db/migrate/20180613081317_create_ci_builds_runner_session.rb

@@ -8,6 +8,7 @@ class CreateCiBuildsRunnerSession < ActiveRecord::Migration[4.2]
   DOWNTIME = false
 
   def change
+    # rubocop:disable Migration/AddLimitToStringColumns
     create_table :ci_builds_runner_session, id: :bigserial do |t|
       t.integer :build_id, null: false
       t.string :url, null: false
@@ -17,5 +18,6 @@ def change
       t.foreign_key :ci_builds, column: :build_id, on_delete: :cascade
       t.index :build_id, unique: true
     end
+    # rubocop:enable Migration/AddLimitToStringColumns
   end
 end