-
- Downloads
There was a problem fetching the pipeline summary.
Fix LFS timeouts when trying to save large files
The following was happening: 1. Workhorse stores an LFS file in /var/opt/gitlab/gitlab-rails/shared/lfs-objects 2. CarrierWave then renames the file to a temporary directory (e.g. /opt/gitlab/embedded/service/gitlab-rails/tmp) 3. CarrierWave then renames the file to its final location (e.g. /var/opt/gitlab/gitlab-rails/shared/lfs-objects) When the LFS upload path was on a different filesystem than the Rails installation, step 2 could take a longer than 10 seconds, at which point Workhorse would time out with "badgateway: failed after 10s: context canceled". This change makes the work path in the same root as the LFS storage path, preventing moves across filesystems. Closes #33218
parent
5cb8ad6c
No related branches found
No related tags found
Pipeline #
This commit is part of merge request !11866. Comments created here will be created in the context of that merge request.
Showing
- app/uploaders/lfs_object_uploader.rb 16 additions, 0 deletionsapp/uploaders/lfs_object_uploader.rb
- changelogs/unreleased/sh-fix-lfs-from-moving-across-filesystems.yml 4 additions, 0 deletions.../unreleased/sh-fix-lfs-from-moving-across-filesystems.yml
- spec/uploaders/lfs_object_uploader_spec.rb 29 additions, 0 deletionsspec/uploaders/lfs_object_uploader_spec.rb
spec/uploaders/lfs_object_uploader_spec.rb
0 → 100644
Please register or sign in to comment