Skip to content
Snippets Groups Projects
Select Git revision
  • as-if-foss/rw/16815-optimization
  • as-if-foss/ps-migrate-vscode-extension-marketplace-ff-to-db
  • as-if-foss/510317-implement-feature-flag
  • as-if-foss/520149-cngo-improve-dev-widget-error
  • as-if-foss/521264-vue3-migration-devops_adoption_overview_table_spec
  • as-if-foss/510851-policies-integration-tests-skip-ci
  • as-if-foss/secret_push_spec_commit_update
  • as-if-foss/517152-duo-enterprise-trial-lead-form
  • master default protected
  • as-if-foss/jnnkl-multi-thread-integration
  • as-if-foss/check-tag-rules-when-deleting-container-images
  • as-if-foss/gems_checksum_lock
  • as-if-foss/521041/aslota-rename-custom-status-widget-to-status-widget
  • as-if-foss/239356/kb/specify-expected
  • as-if-foss/239356-fix-Style/FormatString-1
  • as-if-foss/cngo-inline-tranalations
  • as-if-foss/overdue-finalize-background-migration--backfill-protected-environment-deploy-access-levels-protected-environment-group-id
  • as-if-foss/520026-cngo-fix-group-filter
  • as-if-foss/511232-add-severity-override-metadata-to-mr-widget-calls
  • as-if-foss/515996-add-immutable-to-tag-rules
  • v17.7.6 protected
  • v17.8.4 protected
  • v17.9.1 protected
  • v17.8.3 protected
  • v17.7.5 protected
  • v17.9.0 protected
  • v17.9.0-rc42 protected
  • v17.6.5 protected
  • v17.7.4 protected
  • v17.8.2 protected
  • v17.6.4 protected
  • v17.7.3 protected
  • v17.8.1 protected
  • v17.8.0 protected
  • v17.7.2 protected
  • v17.8.0-rc42 protected
  • v17.5.5 protected
  • v17.6.3 protected
  • v17.7.1 protected
  • v17.7.0 protected
40 results

20161221153951_rename_reserved_project_names.rb

  • Gabriel Mazetto's avatar
    d391dfb4
    Refactored AfterRenameService to reduce coupling · d391dfb4
    Gabriel Mazetto authored
    We still rely on the Dirty API for project rename (before/after) values,
    but we don't access the dirty api from the service class anymore.
    
    The previous value is now part of the initialization, which makes it
    easier to test and the behavior is clearer.
    
    The same was done with the `rename_repo` on the Storage classes, we now
    provide before and after values as part of the method signature.
    d391dfb4
    History
    Refactored AfterRenameService to reduce coupling
    Gabriel Mazetto authored
    We still rely on the Dirty API for project rename (before/after) values,
    but we don't access the dirty api from the service class anymore.
    
    The previous value is now part of the initialization, which makes it
    easier to test and the behavior is clearer.
    
    The same was done with the `rename_repo` on the Storage classes, we now
    provide before and after values as part of the method signature.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.