Deprecation errors for hpa.targetAverageValue with latest Charts version
The latest version of Charts has a deprecation error that prevents GET from deploying this version. I had to make these changes:
diff --git a/ansible/roles/gitlab_charts/templates/gitlab.yml.j2 b/ansible/roles/gitlab_charts/templates/gitlab.yml.j2
index 7746db1..1dcc838 100644
--- a/ansible/roles/gitlab_charts/templates/gitlab.yml.j2
+++ b/ansible/roles/gitlab_charts/templates/gitlab.yml.j2
@@ -7,7 +7,8 @@ gitlab:
maxReplicas: "{{ gitlab_charts_webservice_max_replicas if gitlab_charts_webservice_max_replicas != '' else webservice_pods }}"
minReplicas: "{{ gitlab_charts_webservice_min_replicas if gitlab_charts_webservice_min_replicas != '' else (webservice_pods | int * gitlab_charts_webservice_min_replicas_scaler) | int }}"
hpa:
- targetAverageValue: 1600m
+ cpu:
+ targetAverageValue: 1600m
resources:
limits:
memory: "{{ webservice_limits_memory_gb }}G"
@@ -36,7 +37,8 @@ gitlab:
minReplicas: "{{ gitlab_charts_sidekiq_min_replicas if gitlab_charts_sidekiq_min_replicas != '' else (sidekiq_pods | int * gitlab_charts_sidekiq_min_replicas_scaler) | int }}"
concurrency: "{{ sidekiq_max_concurrency }}"
hpa:
- targetAverageValue: 700m
+ cpu:
+ targetAverageValue: 700m
resources:
limits:
memory: "{{ gitlab_charts_sidekiq_limits_memory_gb }}G"
The changes aren't backwards compatible, so I wonder if we have to worry about which Charts version is being used.
For reference, we used this to test a devel version of Charts. See #482 (closed) for more details:
diff --git a/ansible/roles/gitlab_charts/tasks/main.yml b/ansible/roles/gitlab_charts/tasks/main.yml
index 18403ff..baf7dd9 100644
--- a/ansible/roles/gitlab_charts/tasks/main.yml
+++ b/ansible/roles/gitlab_charts/tasks/main.yml
@@ -146,7 +146,7 @@
- name: Add GitLab Charts repo
kubernetes.core.helm_repository:
name: gitlab
- repo_url: "https://charts.gitlab.io/"
+ repo_url: "https://gitlab.com/api/v4/projects/3828396/packages/helm/devel"
tags:
- reconfigure
- charts
@@ -210,7 +210,7 @@
kubernetes.core.helm:
name: gitlab
chart_ref: gitlab/gitlab
- chart_version: "{{ gitlab_charts_version | default(None) }}"
+ chart_version: "6.1.3-591872203" # "{{ gitlab_charts_version | default(None) }}"
update_repo_cache: true
release_namespace: "{{ gitlab_charts_release_namespace }}"
values: "{{ gitlab_charts_values }}"
Be sure to run helm remove gitlab
to allow this to work.
Edited by Stan Hu