Either GET should fix the AWS EKS Cluster version or should make it configurable
At present, aws_eks_cluster
does not stipulate an EKS version.
This means that the version of the cluster will be set depending on the latest available version set at the time of creation.
It would be better if the EKS version number was controlled/deterministic:
- Either fixed as part of the GET version, and occasionally updated once new EKS versions had been verified as working with GET/GitLab.
- Something that can be configured on the module, allowing the GET customer to configure this.
Both approaches have their advantages and disadvantages, and I'll leave the choice open to discussion.
Implementation can be done via the version
attribute on the aws_eks_cluster
resource: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/eks_cluster#version:
version
– (Optional) Desired Kubernetes master version. If you do not specify a value, the latest available version at resource creation is used and no upgrades will occur except those automatically triggered by EKS. The value must be configured and increased to upgrade the version when desired. Downgrades are not supported by EKS.
Related issue: https://gitlab.com/gitlab-com/gl-infra/gitlab-dedicated/team/-/issues/670