Follow-up from "Pass configurable file size limit to gitlab-elasticsearch-indexer"
The following discussion from !84 (merged) should be addressed:
-
@mbergeron started a discussion: (+2 comments) I think we could embed the
Encodertype in theIndexertype, as it is required by theIndexertype.This would remove a couple references to
encoderfrom within theIndexerfunctions, as all the methods ofEncoderwill be available directly on theIndexer— actually allIndexerwould the be anEncoder.Side note here, I just want to point out that even if we embed
Submitterwe are not leveraging the type embedding inIndexerfunctions. We should do that, but not now.