Improve Geo architecture diagram
What does this MR do?
This is my proposal to remove the confusion @sytses
raised.
Source: https://docs.google.com/drawings/d/1EQKRfTJH_9m_ChMb21AURBXUlpU0jF4KeMUhs6MLcC0/edit
What are the relevant issue numbers?
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process. -
EE specific content should be in the top level /ee
folder -
For a paid feature, have we considered GitLab.com plans, how it works for groups, and is there a design for promoting it to users who aren't on the correct plan? -
Security reports checked/validated by reviewer
Merge request reports
Activity
@rnienaber @brodock I was watching the GC recording, WDYT?
assigned to @rnienaber
added documentation + 1 deleted label
1 Error 3d6dede7: The commit subject must contain at least three words 1 Message This merge request adds or changes files that require a review from the Technical Writing team whether before or after merging. Documentation review
The following files will require a review from the Technical Writing team:
doc/administration/geo/replication/img/geo_architecture.png
Per the documentation workflows, the review may occur prior to merging this MR or after a maintainer has agreed to review and merge this MR without a tech writer review. (Meanwhile, you are welcome to involve a technical writer at any time if you have questions about writing or updating the documentation. GitLabbers are also welcome to use the #docs channel on Slack.)
The technical writer who, by default, will review this content or collaborate as needed is dependent on the DevOps stage to which the content applies:
Tech writer Stage(s) @marcia
~Create ~Release + development guidelines @axil
~Distribution ~Gitaly ~Gitter ~Monitor ~Package ~Secure @eread
~Manage ~Configure ~Geo ~Verify @mikelewis
~Plan To request a review prior to merging
- Assign the MR to the applicable technical writer, above. If you are not sure which category the change falls within, or the change is not part of one of these categories, mention one of the usernames above.
To request a review to commence after merging
- Create an issue for a doc review using the Doc Review template and assign it to the applicable technicial writer from the table.
Commit message standards
One or more commit messages do not meet our Git commit message standards. For more information on how to write a good commit message, take a look at How to Write a Git Commit Message.
Here is an example of a good commit message:
Reject ruby interpolation in externalized strings When using ruby interpolation in externalized strings, they can't be detected. Which means they will never be presented to be translated. To mix variables into translations we need to use `sprintf` instead. Instead of: _("Hello #{subject}") Use: _("Hello %{subject}") % { subject: 'world' }
This is an example of a bad commit message:
updated README.md
This commit message is bad because although it tells us that README.md is updated, it doesn't tell us why or how it was updated.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer ~Documentation Mike Lewis ( @mikelewis
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖changed milestone to %11.9
could the "Push Proxy" box be smaller so that the red lines on the secondary could be straight?
@rnienaber Great idea... Done!
In the new version I think the Git logo is not needed anymore
Edited by Gabriel Mazettoassigned to @toon
@dbalexandre this is very ~Geo specific, so do you mind being the maintainer here?
I've removed the git logo as @rnienaber requested.
Edited by Toon Claesassigned to @dbalexandre
Thanks, @toon! MWPS set
enabled an automatic merge when the pipeline for 3d6dede7 succeeds
mentioned in commit c8ecee88
mentioned in issue gitlab-org/release/tasks#731 (closed)
added devopssystems groupgeo labels
added Enterprise Edition label