Skip to content

Compute approved approver for merged MR if it is absent

Mark Chao requested to merge 9889-fix-finalize into master

What does this MR do?

For merged MRs which does not have approved_approvers, compute approved approvers like open MR.

Fix #9913 (closed), in which visiting past merged MR with project rule only would cause 500 error. Those MRs does not have project level rule copied as MR-level rule, so they requires computing approved approvers dynamically.

What are the relevant issue numbers?

Close #9889 (closed)
Close #9913 (closed)
Close #9866 (closed)

Does this MR meet the acceptance criteria?

Closes #9889 (closed)

Edited by Mark Chao

Merge request reports