(Part 9) Multiple approval rules - docs
What does this MR do?
This MR updates the merge_request_approval
docs for the new "Multiple approval rules" feature. Please note that it points to a feature branch (not master
) and that the changes described in the docs are behind a feature flag (disabled for now).
Related issues
Part of #1979 (closed)
Author's checklist
-
Apply the correct labels and milestone -
Crosslink the document from the higher-level index -
Crosslink the document from other subject-related docs -
Feature moving tiers? Make sure the change is also reflected in features.yml
-
Correctly apply the product badges and tiers -
Port the MR to EE (or backport from CE): always recommended, required when the ee-compat-check
job fails
Review checklist
-
Your team's review (required) -
PM's review (recommended, but not a blocker) -
Technical writer's review (required) -
Merge the EE-MR first, CE-MR afterwards
/label ~Documentation
Merge request reports
Activity
changed milestone to %11.8
added Create [DEPRECATED] Deliverable GitLab Premium approvals backend customer customer+ devopscreate direction frontend merge requests missed-deliverable missed:11.7 missed:11.8 priority1 ~2975006 workflowin review + 1 deleted label
mentioned in merge request !9001 (merged)
added 5 commits
-
22da9c4f...1d79b86d - 4 commits from branch
1979-fe-multiple-approval-rules
- 85afddaf - Update docs for multiple approval rules
-
22da9c4f...1d79b86d - 4 commits from branch
1 Message This merge request adds or changes files that require a review from the Docs team. Docs review
The following files require a review from the Documentation team:
doc/user/project/merge_requests/img/approvals_starter_project_edit.png
doc/user/project/merge_requests/img/approvals_starter_project_empty.png
doc/user/project/merge_requests/img/approvals_ultimate_mr_widget.png
doc/user/project/merge_requests/img/approvals_ultimate_project_edit.png
doc/user/project/merge_requests/img/approve.png
doc/user/project/merge_requests/img/approve_additionally.png
doc/user/project/merge_requests/img/remove_approval.png
doc/user/project/merge_requests/merge_request_approvals.md
When your content is ready for review, assign the MR to a technical writer according to the DevOps stages in the table below. If necessary, mention them in a comment explaining what needs to be reviewed.
Tech writer Stage(s) @marcia
~Create ~Release + development guidelines @axil
~Distribution ~Gitaly ~Gitter ~Monitor ~Package ~Secure @eread
~Manage ~Configure ~Geo ~Verify @mikelewis
~Plan You are welcome to mention them sooner if you have questions about writing or updating the documentation. GitLabbers are also welcome to use the #docs channel on Slack.
If you are not sure which category the change falls within, or the change is not part of one of these categories, mention one of the usernames above.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖Hey @marcia! Could you please review this docs MR for multiple approval rules? Please note that this MR doesn't point to
master
(it points to a feature branch). Also, the features described in these changes are behind a feature flag which is disabled by default. I'm not sure if that changes how/when this should be mergedassigned to @marcia
- Resolved by Paul Slaughter
- Resolved by Paul Slaughter
- Resolved by Paul Slaughter
- Resolved by Paul Slaughter
- Resolved by Paul Slaughter
- Resolved by Marcia Ramos
- Resolved by Paul Slaughter
- Resolved by Paul Slaughter
- Resolved by Marcia Ramos
- Resolved by Marcia Ramos
- Resolved by Paul Slaughter
- Resolved by Marcia Ramos
- Resolved by Marcia Ramos
Awesome, thanks @pslaughter! I've left a few comments, please assign it back to me when done.
assigned to @pslaughter
added documentation label
marked the checklist item Apply the correct labels and milestone as completed
Thanks for the quick response @marcia! I replied to your comments and changed the MR description. Back to you!
assigned to @marcia
Thanks @pslaughter! We're good to go. Why have you set the target to a feature branch instead of
master
? Should I merge it?mentioned in commit 3a16953c
Automatically picked into https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9534, will merge into
11-8-stable-ee
ready for11.8.0-rc4-ee
.mentioned in commit cd4284f0
mentioned in merge request !9534 (merged)
mentioned in merge request !9455 (merged)
mentioned in merge request gitlab-com/www-gitlab-com!18225 (merged)
mentioned in merge request !9618 (merged)