Skip to content

Model changes for code owner approval rules

What does this MR do?

This is a first step in https://gitlab.com/gitlab-org/gitlab-ee/issues/4418 not all code is used in this MR, but it will be in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9293.

This adds a partial unique index for approval_merge_request_rules, the name must be unique scoped to a merge request when code_owners = 't'. This is also enforced by validations. A helper method for creating/finding code owner rules avoiding race conditions.

This index is safe to add, as we already only create one code_owner row in that table. Now the database will enforce this.

Does this MR meet the acceptance criteria?

Edited by Alexandru Croitor

Merge request reports