WIP: Put Rugged::FindCommit back into 11.5.7 EE
On one system, we saw Gitaly's FindCommit
request launching many git cat-file
calls per request, which caused unnecessary load when Gitaly is run atop of NFS.
By putting back Rugged, this eliminates many of the N+1 Gitaly queries called in FindCommit
. The repository is loaded once, and all subsequent loads for commits are much cheaper.
To apply this patch:
curl -o /tmp/9377.patch https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9377.diff
cd /opt/gitlab/embedded/service/gitlab-rails
patch -p1 < /tmp/9377.patch
Merge request reports
Activity
3 Errors Please add labels to this merge request. 15702b90: The commit subject must contain at least three words 633a9810: Commits that change 30 or more lines in more than three files must describe these changes in the commit body 4 Warnings This merge request does not refer to an existing milestone. Most of the time, merge requests should target master
. Otherwise, please set the relevantPick into X.Y
label.CHANGELOG missing. You can create one with:
bin/changelog -m 9377 "Put Rugged::FindCommit back into 11.5.7 EE"
If your merge request doesn’t warrant a CHANGELOG entry,
consider adding any of the ~backstage, ~Documentation, QA, test labels.
See the documentation.You’ve made some app changes, but didn’t add any tests.
That’s OK as long as you’re refactoring existing code,
but please consider adding any of the ~backstage, ~Documentation, QA labels.Commit message standards
One or more commit messages do not meet our Git commit message standards. For more information on how to write a good commit message, take a look at How to Write a Git Commit Message.
Here is an example of a good commit message:
Reject ruby interpolation in externalized strings When using ruby interpolation in externalized strings, they can't be detected. Which means they will never be presented to be translated. To mix variables into translations we need to use `sprintf` instead. Instead of: _("Hello #{subject}") Use: _("Hello %{subject}") % { subject: 'world' }
This is an example of a bad commit message:
updated README.md
This commit message is bad because although it tells us that README.md is updated, it doesn't tell us why or how it was updated.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖Hi @stanhu,
Please add labels to your merge request, this helps triage community merge requests.
Thanks for your help!
You are welcome to help improve this comment.
added auto updated label
mentioned in merge request !9403 (closed)
added backend + 1 deleted label
This was only created for a customer. Closing in favor of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25477.
mentioned in merge request !9989 (closed)
mentioned in epic &827
mentioned in epic &1190 (closed)
added devopscreate groupgitaly labels
added Enterprise Edition label