Skip to content
Snippets Groups Projects

Epics relantioship API

Merged Felipe Cardozo requested to merge issue_7326 into master
All threads resolved!

What does this MR do?

Add API endpoints for listing, adding and removing related epics.

What are the relevant issue numbers?

closes #7326 (closed)

Does this MR meet the acceptance criteria?

Edited by Felipe Cardozo

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thanks @felipe_artur, nice work. I left some comments inline.

  • Felipe Cardozo added 1 commit

    added 1 commit

    Compare with previous version

  • thanks for the review @jprovaznik, addressed all comments. Do you mind taking another look?

  • Felipe Cardozo unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Felipe Cardozo added 2 commits

    added 2 commits

    Compare with previous version

  • Thanks @felipe_artur, one more comment about deletion, otherwise LGTM.

  • @jprovaznik

    Because we define "parent" of an epic by creating a new association on parent epic (instead of updating child epic with epic's parent id)

    I think i did not understand. When we associate a child epic we update its parent_id with the epic id.

  • Felipe Cardozo added 1 commit

    added 1 commit

    Compare with previous version

  • @felipe_artur I think what @jprovaznik is saying is that to add a link, we have this endpoint:

    Assign a child epic

    This operates on the parent, not the child. So it would make sense for the deletion to also act on the parent. (I agree.)

  • Sean McGivern
  • Sean McGivern resolved all discussions

    resolved all discussions

  • Felipe Cardozo added 1 commit

    added 1 commit

    Compare with previous version

  • Felipe Cardozo added 1 commit

    added 1 commit

    Compare with previous version

  • Felipe Cardozo added 1 commit

    added 1 commit

    • eff9e0db - Re-use epic fixture on specs

    Compare with previous version

  • Felipe Cardozo
  • Sean McGivern resolved all discussions

    resolved all discussions

  • Sean McGivern approved this merge request

    approved this merge request

  • mentioned in issue #7328 (closed)

  • Mike Lewis
  • Mike Lewis
  • @felipe_artur I left some comments and suggestions on the docs.

  • Felipe Cardozo added 1373 commits

    added 1373 commits

    Compare with previous version

  • Felipe Cardozo added 1 commit

    added 1 commit

    • 767d350a - Apply suggestion to doc/api/epic_links.md

    Compare with previous version

  • Felipe Cardozo added 1 commit

    added 1 commit

    • 19086f48 - Apply suggestion to doc/api/epic_links.md

    Compare with previous version

  • Thanks @mikelewis. I made the changes you requested.

    Can you check again please?

  • Felipe Cardozo added 1 commit

    added 1 commit

    Compare with previous version

  • Felipe Cardozo added 344 commits

    added 344 commits

    Compare with previous version

  • Felipe Cardozo added 1 commit

    added 1 commit

    Compare with previous version

  • Mike Lewis resolved all discussions

    resolved all discussions

  • Mike Lewis added 1 commit

    added 1 commit

    Compare with previous version

  • Thank you @mikelewis!

    @smcgivern Assigning back to you.

  • merged

  • Sean McGivern mentioned in commit 476af7a9

    mentioned in commit 476af7a9

  • mentioned in issue #26548

  • Please register or sign in to reply
    Loading