Assign approvers based on code owners
Compare changes
Files
2@@ -620,7 +620,7 @@ def set_compare(merge_request)
@@ -634,7 +634,7 @@ def set_compare(merge_request)
@@ -665,7 +665,7 @@ def set_compare(merge_request)
The CE port is at https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22513
Assign approvers based on code owners
The major changes are:
overall_approvers
method now returns User
instead of Approver
. This is because it needs to include code owners, which are dynamically calculated therefore does not have a corresponding Approver
column.overall_approvers
are changed to work with User
instead.user_id
instead. This is because we only have User
instead of Approver
, and if we want to get an user's approver it would cause extra database queries. At the end I decided to allow deleting of approvers by using user_id
instead.Closes #1012 (closed)
/ee
folder