Skip to content
Snippets Groups Projects

Remove Koding integration and documentation (EE port)

Merged Stan Hu requested to merge sh-remove-koding-ee into master

This integration no longer works and does not appear to be supported.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/39697

CE port: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22334

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Stan Hu added 1 commit

    added 1 commit

    • c8e497c7 - Remove Koding integration and documentation

    Compare with previous version

  • 1 Error
    :no_entry_sign: ff5887a8: Commits that change 30 or more lines in more than three files must describe these changes in the commit body
    4 Warnings
    :warning: This merge request is quite big (more than 1075 lines changed), please consider splitting it into multiple merge requests.
    :warning: CHANGELOG missing.

    You can create one with:

    bin/changelog -m 7917 "Remove Koding integration and documentation (EE port)"

    If your merge request doesn’t warrant a CHANGELOG entry,
    consider adding any of the ~backstage, ~Documentation, QA, test labels.
    See the documentation.

    :warning: This merge request is missing the database label.
    :warning: This merge request is missing the ~Documentation label.
    2 Messages
    :book: This merge request adds or changes files that require a review from the Database team.
    :book: This merge request adds or changes files that require a review from the docs team.

    Database Review

    The following files require a review from the Database team:

    • db/post_migrate/20181013005024_remove_koding_from_application_settings.rb
    • db/schema.rb

    To make sure these changes are reviewed, take the following steps:

    1. Edit your merge request, and add gl-database to the list of Group approvers.
    2. Mention @gl-database in a separate comment, and explain what needs to be reviewed by the team. Please don't mention the team until your changes are ready for review.

    Docs Review

    The following files require a review from the Documentation team:

    • doc/api/settings.md
    • doc/user/reserved_names.md

    To make sure these changes are reviewed, mention @gl-docsteam in a separate comment, and explain what needs to be reviewed by the team. Please don't mention the team until your changes are ready for review.

    Commit message standards

    One or more commit messages do not meet our Git commit message standards. For more information on how to write a good commit message, take a look at How to Write a Git Commit Message.

    Here is an example of a good commit message:

    Reject ruby interpolation in externalized strings
    
    When using ruby interpolation in externalized strings, they can't be
    detected. Which means they will never be presented to be translated.
    
    To mix variables into translations we need to use `sprintf`
    instead.
    
    Instead of:
    
        _("Hello #{subject}")
    
    Use:
    
        _("Hello %{subject}") % { subject: 'world' }

    This is an example of a bad commit message:

    updated README.md

    This commit message is bad because although it tells us that README.md is updated, it doesn't tell us why or how it was updated.

    Generated by :no_entry_sign: Danger

    Edited by 🤖 GitLab Bot 🤖
  • Stan Hu added 1 commit

    added 1 commit

    • 8b555945 - Remove Koding integration and documentation

    Compare with previous version

  • Stan Hu added 1 commit

    added 1 commit

    • ff5887a8 - Remove unneeded I8N text for Koding

    Compare with previous version

  • Douwe Maan approved this merge request

    approved this merge request

  • merged

  • Douwe Maan mentioned in commit a4346644

    mentioned in commit a4346644

Please register or sign in to reply
Loading