Skip to content
Snippets Groups Projects

Resolves "Reviews: Resolving or unresolving discussions with “Add comment now” does not work"

Merged André Luís requested to merge 7921-fix-batch-comments-resolution into master

:warning: CE backport here: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22303

What does this MR do?

In the batch comments feature, when you submit the comment right away, without saving it as draft first, the resolution of discussion wasn't working properly.

This adds a check that will recognize whether BatchComments are active or not and check the checkbox properly when commenting right away.

It also adds rspec tests to cover the scenarios of resolving/unresolving both when adding comment right away as well as through draft => publish review flow.

What are the relevant issue numbers?

Closes #7921 (closed)

Does this MR meet the acceptance criteria?

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading