Add timeline icon for issue weights
What does this MR do?
Adds timeline icon for issue weights according to #5340 (closed).
Before | After |
---|---|
![]() |
![]() |
What are the relevant issue numbers?
Closes #7121 (closed)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
EE specific content should be in the top level /ee
folder -
For a paid feature, have we considered GitLab.com plans, how it works for groups, and is there a design for promoting it to users who aren't on the correct plan?
Merge request reports
Activity
marked the checklist item Changelog entry added, if necessary as completed
I've updated the timeline icon to match the updated icon in #5340 (closed). Should we use the
scale
icon and update all weight icons later instead? /cc @sarrahvesselov @akaemmerlescale
iconweight
iconEdited by George TsiolisI agree @akaemmerle. I've updated description and code. %11.6 sounds good! %11.5 could replace some more font icons left behind (like https://gitlab.com/gitlab-org/gitlab-ce/issues/47009), following changes in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20748.
Edited by George Tsiolis@jkarthik could you review UX here? See also https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/7847#note_107482041.
Edited by George Tsiolisadded Community contribution label
Looks good @gtsiolis
assigned to @iamphill
added workflowin review label
Thanks @akaemmerle! I think %11.5 is also appropriate here, right?
changed milestone to %11.5
@iamphill is on vacation. @annabeldunstone could you review and merge this, or forward to another maintainer?
assigned to @ClemMakesApps
@ClemMakesApps Mind having a last look on this contribution here and merge? Thank you!
LGTM, Thanks @gtsiolis
mentioned in commit 6a662c68
Thanks @ClemMakesApps @jkarthik @akaemmerle!
mentioned in issue gitlab-org/release/tasks#515 (closed)
mentioned in merge request !8448 (merged)
changed milestone to %11.6
added Enterprise Edition label