Skip to content

Rails5 fix commit statuses spec

Jasper Maes requested to merge jlemaes/gitlab-ee:rails5-fix-7087 into master

What does this MR do?

Disable Sidekiq inline testing in order not to hit the query limit. This was happening for Rails 5.

The extra sql queries are 5 extra SAVEPOINT active_record_1 and RELEASE SAVEPOINT active_record_1 pairs. However, the query logs of Rails 4 from development have these same transactions for this endpoint. I compared the query logs of the specs of Rails 5 with the logs of this endpoint in Rails 4(with sidekiq inline enabled) and they had the same commit(or savepoint in specs) queries.

Since this is an inconsistency in Rails 4 testing, I decided just to turn off sidekiq inline testing to prevent the requests from hitting the query limit as the queries from inline sidekiq workers are counted in the query limiting check.

What are the relevant issue numbers?

Closes #7087 (closed)

Does this MR meet the acceptance criteria?

Merge request reports