EE Port of: Remove fixes for MR refactor regressions from master
What does this MR do?
This Ports the reverts of the MR Refactor fixes that are to be removed from master as per: the CE counterpart https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20920
Description copied from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20920 below:
What does this MR do?
It remove the fixes that were deemed to worsen performance while picking for 11.1.3.
This is following the plan devised with Release team whereby doing this we'll avoid the performance degradation caused by this set of fixes (exact culprit still to be 100% determined) from blocking 11.2 RC1, to be tagged within the next days.
These fixes will be brought back once the performance is better than 11.1.2.
Are there points in the code the reviewer needs to double check?
Re-adding the fixes will be done into a separate integration branch after checking performance does not degrade on each one.
I also believe due to the nature of this MR, squashing might not be ideal.
Why was this MR needed?
11.1.3 was aborted because instead of improving performance, in some very large MRs the performance worsened significantly.
Screenshots (if relevant)
Please see gitlab-org/release/tasks#375 (comment 91153731)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bugTests reverted/updated. - Conforms to the code review guidelines
-
Has been reviewed by a UX Designer -
Has been reviewed by a Frontend maintainer
-
-
Conforms to the merge request performance guidelines -
Conforms to the style guides -
If you have multiple commits, please combine them into a few logically organized commits by squashing them