Skip to content

Rails5 fix NoMethodError: undefined method 'message' for nil:NilClass

Jasper Maes requested to merge jlemaes/gitlab-ee:rails5-fix-6605 into master

What does this MR do?

Fix Rails5 specs to wrap the exceptions for Rails 5 instead of passing it to the initialiser. Rails commit: https://github.com/rails/rails/commit/266455cf25aba942b8717ceb0269d66f719b5696

Are there points in the code the reviewer needs to double check?

Is there a better way to mock wrapped exceptions? 🤷

Why was this MR needed?

rails5 upgrade

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #6605 (closed)

Edited by Yorick Peterse

Merge request reports