Skip to content
Snippets Groups Projects

port 48578-disable-gcp-free-credit-banner-at-instance-level to EE

All threads resolved!

What does this MR do?

ports https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20379/ to EE

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests added for this feature/bug
  • Conform by the code review guidelines
    • Has been reviewed by a UX Designer
    • Has been reviewed by a Frontend maintainer
    • Has been reviewed by a Backend maintainer
    • Has been reviewed by a Database specialist
  • EE specific content should be in the top level /ee folder
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Conform by the database guides
  • If you have multiple commits, please combine them into a few logically organized commits by squashing them
  • Internationalization required/considered
  • If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
  • End-to-end tests pass (package-and-qa manual pipeline job)

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/48578

Edited by Rémy Coutable

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • assigned to @dennis

  • Dennis Tang changed the description

    changed the description

  • Dennis Tang added 1 commit

    added 1 commit

    • 85d5971e - Fix order of settings in show.html.haml

    Compare with previous version

  • assigned to @rymai

  • Rémy Coutable resolved all discussions

    resolved all discussions

  • assigned to @dennis

  • @dennis Could you please update this MR with the latest changes for locale/gitlab.pot too?

  • Dennis Tang added 1 commit

    added 1 commit

    Compare with previous version

  • Dennis Tang added 136 commits

    added 136 commits

    Compare with previous version

  • Author Developer

    @rymai locale/gitlab.pot updated.

  • assigned to @rymai

  • Rémy Coutable resolved all discussions

    resolved all discussions

  • Rémy Coutable approved this merge request

    approved this merge request

  • Rémy Coutable marked the checklist item Has been reviewed by a Backend maintainer as completed

    marked the checklist item Has been reviewed by a Backend maintainer as completed

  • Rémy Coutable marked the checklist item Changelog entry added, if necessary as completed

    marked the checklist item Changelog entry added, if necessary as completed

  • Rémy Coutable marked the checklist item Documentation created/updated as completed

    marked the checklist item Documentation created/updated as completed

  • Rémy Coutable marked the checklist item Tests added for this feature/bug as completed

    marked the checklist item Tests added for this feature/bug as completed

  • Rémy Coutable marked the checklist item EE specific content should be in the top level /ee folder as completed

    marked the checklist item EE specific content should be in the top level /ee folder as completed

  • Rémy Coutable marked the checklist item Conform by the merge request performance guides as completed

    marked the checklist item Conform by the merge request performance guides as completed

  • Rémy Coutable marked the checklist item Conform by the style guides as completed

    marked the checklist item Conform by the style guides as completed

  • Rémy Coutable marked the checklist item Conform by the database guides as completed

    marked the checklist item Conform by the database guides as completed

  • Rémy Coutable marked the checklist item If you have multiple commits, please combine them into a few logically organized commits by squashing them as completed

    marked the checklist item If you have multiple commits, please combine them into a few logically organized commits by squashing them as completed

  • Rémy Coutable marked the checklist item If you have multiple commits, please combine them into a few logically organized commits by squashing them as incomplete

    marked the checklist item If you have multiple commits, please combine them into a few logically organized commits by squashing them as incomplete

  • Rémy Coutable marked the checklist item If you have multiple commits, please combine them into a few logically organized commits by squashing them as completed

    marked the checklist item If you have multiple commits, please combine them into a few logically organized commits by squashing them as completed

  • Rémy Coutable marked the checklist item Internationalization required/considered as completed

    marked the checklist item Internationalization required/considered as completed

  • Rémy Coutable marked the checklist item If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan as completed

    marked the checklist item If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan as completed

  • Rémy Coutable marked the checklist item End-to-end tests pass (package-and-qa manual pipeline job) as completed

    marked the checklist item End-to-end tests pass (package-and-qa manual pipeline job) as completed

  • Rémy Coutable mentioned in commit 5d638022

    mentioned in commit 5d638022

  • Author Developer
  • Rémy Coutable mentioned in commit a9478fec

    mentioned in commit a9478fec

  • Picked into 11-1-stable will be in 11.1.0-rc13

  • Rémy Coutable mentioned in commit 032e5493

    mentioned in commit 032e5493

  • Please register or sign in to reply
    Loading