Skip to content

Secret variable settings update

Constance Okoghenun requested to merge secret-variable-settings-update into master

What does this MR do?

Update UI for secret variable settings

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

#5313 (closed)

Screenshots (if relevant)

Before After
Screen_Shot_2018-07-23_at_11.42.04_AM Screen_Shot_2018-08-07_at_9.43.59_PM
Screen_Shot_2018-07-23_at_11.42.53_AM Screen_Shot_2018-08-07_at_9.45.33_PM

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • API support added
  • Tests added for this feature/bug
  • Conform by the code review guidelines
    • Has been reviewed by a UX Designer
    • Has been reviewed by a Frontend maintainer
  • EE specific content should be in the top level /ee folder
  • Conform by the merge request performance guides
  • Conform by the style guides
  • If you have multiple commits, please combine them into a few logically organized commits by squashing them
  • Internationalization required/considered
  • If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
  • End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

#5313 (closed)

Closes #5313 (closed)

Edited by Jason Yavorska

Merge request reports