Skip to content

Epics - include ::Issuable, not EE::Issuable

Mario de la Ossa requested to merge fix_epics into master

What does this MR do?

The new EE::Issuable::CommonsystemNotesService creates the EE::Issuable module, which, because of the way Rails name lookup works, then gets included in EE::Epics.

All we need to fix it is scope the include to the root-level Issuable module.

cc/ @stanhu

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
    • Has been reviewed by Backend
    • Has been reviewed by Database
  • EE specific content should be in the top level /ee folder
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
  • Internationalization required/considered
  • If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
  • End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

Edited by Nick Thomas

Merge request reports