Skip to content

Fix crash when checking external authorization license

Bob Van Landuyt requested to merge bvl-fix-external-auth-license-check into master

What does this MR do?

This fixes a crash when trying to access something the user does not have access to.

When the external authorization service is disables, we still read the Project#external_authorization_service_classification_label attribute. Which performs a license check directly on the project instead of on License. Which would cause the argument error.

Does this MR meet the acceptance criteria?

  • [ ] Changelog entry added, if necessary
  • [ ] Documentation created/updated
  • [ ] API support added
  • Tests added for this feature/bug
  • Review
    • [ ] Has been reviewed by UX
    • [ ] Has been reviewed by Frontend
    • Has been reviewed by Backend
    • [ ] Has been reviewed by Database

What are the relevant issue numbers?

Fixes https://gitlab.com/gitlab-org/gitlab-ee/issues/5203

Edited by Bob Van Landuyt

Merge request reports