Skip to content

Memoize MergeRequest#rebase_in_progress? to prevent N+1 queries in Gitaly

Stan Hu requested to merge sh-fix-rebase-in-progress-nplus-one into master

MergeRequest#rebase_in_progress? and MergeRequest#rebase_path were called twice each time per request. This memoization helps reduce the overall number of queries.

See https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/51616319 as a failing job.

Closes gitlab-org/gitlab-ee#4857

Edited by Coung Ngo

Merge request reports